-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1521 Fix skip scenario retry #218
Conversation
I think this is a little bit simpler. We want to simulate just a single scenairo, whose result is first a failure, then on the subsequent retry is a skipped result.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that the code in the test looked a bit funny with the line that stubs the ==
method on the Test::Case
I pushed a commit that simplifies things a bit.
Does it make sense?
Hi @eduardrudko, Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾 In return for this generous offer we hope you will:
On behalf of the Cucumber core team, |
Welcome @eduardrudko! Please feel free to start reviewing and merging other people's pull requests if you feel so inclined. |
@mattwynne, @aslakhellesoy Lovely! |
Is your pull request related to a problem? Please describe.
cucumber/cucumber-ruby#1521
Describe the solution you have implemented
Added check on skipped result fo flaky test cases
Additional context
cucumber/cucumber-ruby#1531 closed PR with full stack test