Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1521 Fix skip scenario retry #218

Merged
merged 3 commits into from
May 17, 2021

Conversation

eduardrudko
Copy link
Contributor

Is your pull request related to a problem? Please describe.

cucumber/cucumber-ruby#1521

Describe the solution you have implemented
Added check on skipped result fo flaky test cases

Additional context
cucumber/cucumber-ruby#1531 closed PR with full stack test

eduardrudko and others added 3 commits May 7, 2021 22:39
I think this is a little bit simpler. We want to simulate just a single
scenairo, whose result is first a failure, then on the subsequent retry
is a skipped result.
Copy link
Member

@mattwynne mattwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that the code in the test looked a bit funny with the line that stubs the == method on the Test::Case

I pushed a commit that simplifies things a bit.

Does it make sense?

spec/cucumber/core/report/summary_spec.rb Outdated Show resolved Hide resolved
@mattwynne mattwynne merged commit 2ba4309 into cucumber:main May 17, 2021
@aslakhellesoy
Copy link
Contributor

Hi @eduardrudko,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@mattwynne
Copy link
Member

Welcome @eduardrudko! Please feel free to start reviewing and merging other people's pull requests if you feel so inclined.

mattwynne added a commit that referenced this pull request May 17, 2021
After merge of #218
@eduardrudko
Copy link
Contributor Author

eduardrudko commented May 18, 2021

@mattwynne, @aslakhellesoy Lovely!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants