Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run each test case at most once when using line filters #98

Merged
merged 1 commit into from
Dec 17, 2015

Conversation

brasmusson
Copy link
Contributor

When the locations_filter was created to preserve the filter ordering from the command line when executing the test case (in Cucumber-Ruby-Core v1.1.0/Cucumber-Ruby v2.0.0.rc.4), so that cucumber path/a_feature.feature:10:5 would result in that the test case of line 10 is executed before the test case of line 5, it had the side effect of allowing each test case to executed more than once when using line filter.

Previously cucumber path/a_feature.feature:10:10:10 would result in that the test case of line 10 was executed once (as in Cucumber v1.3.x), now it results in the test case of line 10 is executed three times.

I think this is not what we want.

This PR contains a failing test for this problem, it is preferably fixed together with #96.

@mattwynne
Copy link
Member

Can you see if this still fails when run on top of #99?

@brasmusson brasmusson force-pushed the duplicate-locations-filters branch from 8b2c48f to 95118c6 Compare December 16, 2015 18:56
@brasmusson
Copy link
Contributor Author

Yes, this still failed on top of #99. What is needed is the use of #uniq in LocationsFilter#sorted_test_cases (see 8681d0b). I did merge this onto #99 before applying 8681d0b, so merging #99 now will also merge and close this.

@mattwynne mattwynne merged commit 95118c6 into master Dec 17, 2015
mattwynne added a commit that referenced this pull request Dec 17, 2015
@brasmusson brasmusson deleted the duplicate-locations-filters branch December 17, 2015 13:06
@lock
Copy link

lock bot commented Oct 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants