Merge pull request #1039 from pmatsinopoulos/fix-style-violation-1021…

…-performance-string-replacement

Fixes rubocop violation Performance/StringReplacement

.rubocop_todo.yml

@@ -153,13 +153,12 @@ Performance/RedundantMatch:
     - 'lib/cucumber/deprecate.rb'
     - 'spec/cucumber/formatter/junit_spec.rb'
 
-# Offense count: 5
+# Offense count: 8
 # Cop supports --auto-correct.
-Performance/StringReplacement:
-  Exclude:
-    - 'features/lib/support/feature_factory.rb'
-    - 'lib/cucumber/configuration.rb'
-    - 'lib/cucumber/formatter/json.rb'
+# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
+# SupportedStyles: outdent, indent
+Style/AccessModifierIndentation:
+  Enabled: false
 
 # Offense count: 6
 Style/AccessorMethodName:

features/lib/support/feature_factory.rb

@@ -55,7 +55,7 @@ def generate_step_definition_filename
   end
 
   def filename(name)
-    "features/#{name.downcase.gsub(' ', '_')}.feature"
+    "features/#{name.downcase.tr(' ', '_')}.feature"
   end
 
   def features

lib/cucumber/configuration.rb

@@ -153,7 +153,7 @@ def filters
 
     def feature_files
       potential_feature_files = with_default_features_path(paths).map do |path|
-        path = path.gsub(/\\/, '/') # In case we're on windows. Globs don't work with backslashes.
+        path = path.tr('\\', '/') # In case we're on windows. Globs don't work with backslashes.
         path = path.chomp('/')
 
         # TODO: Move to using feature loading strategies stored in
@@ -179,7 +179,7 @@ def support_to_load
 
     def all_files_to_load
       files = require_dirs.map do |path|
-        path = path.gsub(/\\/, '/') # In case we're on windows. Globs don't work with backslashes.
+        path = path.tr('\\', '/') # In case we're on windows. Globs don't work with backslashes.
         path = path.gsub(/\/$/, '') # Strip trailing slash.
         File.directory?(path) ? Dir["#{path}/**/*"] : path
       end.flatten.uniq

lib/cucumber/formatter/json.rb

@@ -218,7 +218,7 @@ def create_error_message(result)
 
       def encode64(data)
         # strip newlines from the encoded data
-        Base64.encode64(data).gsub(/\n/, '')
+        Base64.encode64(data).delete("\n")
       end
 
       class Builder
@@ -316,7 +316,7 @@ def examples_table_row(row)
         private
 
         def create_id(element)
-          element.name.downcase.gsub(/ /, '-')
+          element.name.downcase.tr(' ', '-')
         end
 
         def create_tags_array(tags)