Skip to content

Commit

Permalink
Merge #1361 'Fix the placeholder expansions in the json formatter'
Browse files Browse the repository at this point in the history
Also update Changelog.md.
  • Loading branch information
brasmusson committed Aug 29, 2019
2 parents ac9a353 + 8e84fb9 commit 7a6c4bc
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ Please visit [cucumber/CONTRIBUTING.md](https://github.com/cucumber/cucumber/blo

### Fixed

* Fix the placeholder expansions in the json formatter
([#1361](https://github.com/cucumber/cucumber-ruby/pull/1361)
[brasmusson](https://github.com/brasmusson))
* Fix seed printed in cucumber UI to match the seed that was actually used.
([#1329](https://github.com/cucumber/cucumber-ruby/pull/1329)
[deivid-rodriguez](https://github.com/deivid-rodriguez))
Expand Down
2 changes: 1 addition & 1 deletion lib/cucumber/formatter/json.rb
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ def scenario(scenario_source, test_case)
@test_case_hash = {
id: "#{@feature_hash[:id]};#{create_id_from_scenario_source(scenario_source)}",
keyword: scenario.keyword,
name: scenario.name,
name: test_case.name,
description: value_or_empty_string(scenario.description),
line: test_case.location.lines.max,
type: 'scenario'
Expand Down
4 changes: 2 additions & 2 deletions spec/cucumber/formatter/json_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ module Formatter
define_feature <<-FEATURE
Feature: Banana party
Scenario Outline: Monkey eats bananas
Scenario Outline: Monkey eats <fruit>
Given there are <fruit>
Examples: Fruit Table
Expand All @@ -189,7 +189,7 @@ module Formatter
"line": 1,
"description": "",
"elements":
[{"id": "banana-party;monkey-eats-bananas;fruit-table;2",
[{"id": "banana-party;monkey-eats-<fruit>;fruit-table;2",
"keyword": "Scenario Outline",
"name": "Monkey eats bananas",
"line": 8,
Expand Down

0 comments on commit 7a6c4bc

Please sign in to comment.