Better deprecation warnings

Ref #942
cucumber · Jan 20, 2016 · 7c6dd80 · 7c6dd80
1 parent 33089a9
commit 7c6dd80
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/lib/cucumber/deprecate.rb b/lib/cucumber/deprecate.rb
@@ -7,7 +7,7 @@ module ForUsers
       AnsiEscapes = Cucumber::Gherkin::Formatter::AnsiEscapes
 
       def self.call(message, method, remove_after_version)
-        STDERR.puts AnsiEscapes.failed + "WARNING: #{method} is deprecated and will be removed after version #{remove_after_version}. #{message}" + AnsiEscapes.reset
+        STDERR.puts AnsiEscapes.failed + "\nWARNING: ##{method} is deprecated and will be removed after version #{remove_after_version}. #{message}.\n(Called from #{caller[2]})" + AnsiEscapes.reset
       end
     end
 

diff --git a/lib/cucumber/running_test_case.rb b/lib/cucumber/running_test_case.rb
@@ -81,12 +81,18 @@ def passed?
       end
 
       def title
-        warn("deprecated: call #name instead")
+        Cucumber.deprecate(
+          "Call #name instead",
+          "RunningTestCase#title",
+          "2.9.9")
         name
       end
 
       def source_tags
-        #warn('deprecated: call #tags instead')
+        Cucumber.deprecate(
+          "Call #tags instead",
+          "RunningTestCase#source_tags",
+          "2.9.9")
         tags
       end
 
@@ -96,8 +102,8 @@ def source_tag_names
 
       def skip_invoke!
         Cucumber.deprecate(
-          "Just call #skip_this_scenario directly",
-          "skip_invoke!",
+          "Call #skip_this_scenario directly (not on any object)",
+          "RunningTestCase#skip_invoke!",
           "2.9.9")
         raise Cucumber::Core::Test::Result::Skipped
       end