Merge pull request #266 from akiellor/jruby-backtraces

Fix ignoring of JRuby backtraces.

cucumber.yml

@@ -13,8 +13,8 @@ end
 default: <%= std_opts %> --dotcucumber features/.cucumber
 jruby: <%= std_opts %> --tags ~@spork --tags ~@wire
 jruby_win: <%= std_opts %> --tags ~@spork --tags ~@wire CUCUMBER_FORWARD_SLASH_PATHS=true
-windows_mri: <%= std_opts %> --tags ~@spork --tags ~@wire --tags ~@needs-many-fonts CUCUMBER_FORWARD_SLASH_PATHS=true
-ruby_1_9: <%= std_opts %> --tags ~@fails_on_1_9
+windows_mri: <%= std_opts %> --tags ~@jruby --tags ~@spork --tags ~@wire --tags ~@needs-many-fonts CUCUMBER_FORWARD_SLASH_PATHS=true
+ruby_1_9: <%= std_opts %> --tags ~@jruby --tags ~@fails_on_1_9
 wip: --tags @wip:3 --wip features
 none: --format pretty
 rerun: <%= rerun_opts %> --format rerun --out rerun.txt --strict --tags ~@wip

features/backtraces.feature

@@ -0,0 +1,36 @@
+Feature: Backtraces
+  In order to discover errors quickly
+  As a cuker
+  I want to see backtraces for failures
+
+  Background:
+    Given a file named "features/failing_hard.feature" with:
+      """
+      Feature: Sample
+        Scenario: Example
+          Given failing
+      """
+
+    @jruby
+  Scenario: Backtraces enabled
+    Given a file named "features/step_definitions/steps.rb" with:
+      """
+      require 'java'
+      java_import 'java.util.Collections'
+
+      Given /^failing$/ do
+        Collections.empty_list.add 1
+      end
+      """
+    When I run `cucumber features/failing_hard.feature`
+    Then it should fail with:
+      """
+      Feature: Sample
+
+        Scenario: Example # features/failing_hard.feature:2
+          Given failing   # features/step_definitions/steps.rb:4
+            java.lang.UnsupportedOperationException: null (NativeException)
+            java/util/AbstractList.java:131:in `add'
+            java/util/AbstractList.java:91:in `add'
+      """
+

lib/cucumber/ast/step_invocation.rb

@@ -94,20 +94,6 @@ def find_step_match!(step_mother, configuration)
       end
 
       def failed(configuration, e, clear_backtrace)
-        if Cucumber::JRUBY && e.class.name == 'NativeException'
-          # JRuby's NativeException ignores #set_backtrace.
-          # We're fixing it.
-          e.instance_eval do
-            def set_backtrace(backtrace)
-              @backtrace = backtrace
-            end
-
-            def backtrace
-              @backtrace
-            end
-          end
-        end
-
         e.set_backtrace([]) if e.backtrace.nil? || clear_backtrace
         e.backtrace << @step.backtrace_line unless @step.backtrace_line.nil?
         e = filter_backtrace(e)