Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rubocop to check the style of the codebase #1014

Closed
nodo opened this issue Sep 5, 2016 · 2 comments · Fixed by #1015
Closed

Add rubocop to check the style of the codebase #1014

nodo opened this issue Sep 5, 2016 · 2 comments · Fixed by #1015

Comments

@nodo
Copy link
Member

nodo commented Sep 5, 2016

What do you think about adding rubocop (http://rubocop.readthedocs.io/en/latest/) to check the style of the codebase?

It doesn't necessarily mean that we need to agree with all the rules enforced by rubocop. However, I find useful to have a consistent style in the codebase after we agree on which rules to use.

I would suggest to add some basic configuration and the run rubocop --auto-gen-config. This will generate a .rubocop_todo.yml which tracks the offences. Then we could gradually fix them.

WDYT?

@mattwynne
Copy link
Member

Agreed, great idea. It will also present great opportunities for first timers contributions to correct the style violations.

nodo pushed a commit to nodo/cucumber-ruby that referenced this issue Sep 7, 2016
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants