-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add junaruga to contributor team #1089
Comments
@mattwynne ok! I am happy to join Hello guys! |
Welcome @junaruga ! |
@mattwynne I have a question. I want to merge below PR by myself from the page. There is no merge button for me. |
@junaruga I think I had set the team permissions up wrong (probably meaning this button was also missing for other recently added team members in @cucumber/cucumber-ruby (sorry folks). Can you try again? |
@mattwynne okay. In case of below PR, I can see the merge button. But in case of |
Ok, try again now? |
@mattwynne |
My bad. Try |
@mattwynne thanks I can see the merge button for |
Welcome to the team @junaruga ! |
Thanks guys. I would close this ticket, as the time has been passed. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Add @junaruga to the
cucumber-ruby
contributor teamDetail
Jun has been doing some great work to help Cucumber support the latest versions of Ruby, and so I've given him the commit bit by adding him to the @cucumber/cucumber-ruby team.
Please say Hello to Jun everyone!
@junaruga please continue using PRs when:
In the case of (2) feel free to go ahead an merge your own PRs. Otherwise I think we should get into the habit of merging one another's wherever possible.
Please also remember that as a committer you'll be expected to set a good example in following and upholding our code of conduct in your interactions with other contributors and users. Do ask me for guidance or advice if you need it.
We can sometimes be found in IM at https://gitter.im/cucumber/contributors if you want to chat.
Welcome @junaruga!
The text was updated successfully, but these errors were encountered: