Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add junaruga to contributor team #1089

Closed
mattwynne opened this issue Mar 2, 2017 · 12 comments
Closed

Add junaruga to contributor team #1089

mattwynne opened this issue Mar 2, 2017 · 12 comments

Comments

@mattwynne
Copy link
Member

mattwynne commented Mar 2, 2017

Summary

Add @junaruga to the cucumber-ruby contributor team

Detail

Jun has been doing some great work to help Cucumber support the latest versions of Ruby, and so I've given him the commit bit by adding him to the @cucumber/cucumber-ruby team.

Please say Hello to Jun everyone!

@junaruga please continue using PRs when:

  1. you want feedback
  2. you want other people to notice your changes

In the case of (2) feel free to go ahead an merge your own PRs. Otherwise I think we should get into the habit of merging one another's wherever possible.

Please also remember that as a committer you'll be expected to set a good example in following and upholding our code of conduct in your interactions with other contributors and users. Do ask me for guidance or advice if you need it.

We can sometimes be found in IM at https://gitter.im/cucumber/contributors if you want to chat.

Welcome @junaruga!

@junaruga
Copy link
Contributor

junaruga commented Mar 2, 2017

@mattwynne ok! I am happy to join cucumber-ruby team.
I will keep in mind for the PR rules, and the code of conduct.

Hello guys!
I suppose that I can contribute mainly for fixing failed tests and improving development environment.

@nodo
Copy link
Member

nodo commented Mar 3, 2017

Welcome @junaruga !

@junaruga
Copy link
Contributor

@mattwynne I have a question.

I want to merge below PR by myself from the page. There is no merge button for me.
I do not have a authority to merge this?
cucumber/gherkin-ruby#2
cucumber/aruba#428

@mattwynne
Copy link
Member Author

@junaruga I think I had set the team permissions up wrong (probably meaning this button was also missing for other recently added team members in @cucumber/cucumber-ruby (sorry folks).

Can you try again?

@junaruga
Copy link
Contributor

junaruga commented Mar 10, 2017

@mattwynne okay.

In case of below PR, I can see the merge button.
cucumber/cucumber-ruby-wire#8

But in case of gherkin, above aruba and below multi_test PR , I can not see the merge button yet.

cucumber/multi_test#9

@mattwynne
Copy link
Member Author

Ok, try again now?

@junaruga
Copy link
Contributor

junaruga commented Mar 10, 2017

@mattwynne gherkin, aruba => I can see the merge button now.
But multi_test => I can not see it yet.

@mattwynne
Copy link
Member Author

My bad. Try multi_test again?

@junaruga
Copy link
Contributor

@mattwynne thanks I can see the merge button for multi_test now!

@danascheider
Copy link
Contributor

Welcome to the team @junaruga !

@junaruga
Copy link
Contributor

junaruga commented Jun 5, 2017

Thanks guys. I would close this ticket, as the time has been passed.

@junaruga junaruga closed this as completed Jun 5, 2017
@lock
Copy link

lock bot commented Oct 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants