Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ruby 2.4.0 and ruby-head in .travis.yml. #428

Merged
merged 1 commit into from
Mar 10, 2017
Merged

Add Ruby 2.4.0 and ruby-head in .travis.yml. #428

merged 1 commit into from
Mar 10, 2017

Conversation

junaruga
Copy link
Contributor

@junaruga junaruga commented Mar 2, 2017

Summary

Add ruby-2.4.0 and ruby-head to .traivs.yml.

Details

Motivation and Context

The details and the motivation is same with cucumber/cucumber-ruby#1087

How Has This Been Tested?

Travis will test it.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@junaruga
Copy link
Contributor Author

junaruga commented Mar 2, 2017

Travis: success
Appveyor: failure

I did not touch appveyor.yml in this PR.
It's not related to this PR, isn't it?

mathieujobin
mathieujobin approved these changes Mar 4, 2017
View reviewed changes
Copy link

@mathieujobin mathieujobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appveyor failures looks unrelated

👍

@junaruga junaruga force-pushed the feature/add-ruby24-ruby-head-in-travis branch from 0ad107e to 924c926 Compare March 9, 2017 18:29
@junaruga
Copy link
Contributor Author

junaruga commented Mar 9, 2017 •
edited
Loading

@mathieujobin Thanks for your review.

@junaruga junaruga mentioned this pull request Mar 10, 2017
Closed
@junaruga junaruga force-pushed the feature/add-ruby24-ruby-head-in-travis branch from 924c926 to b2a5940 Compare March 10, 2017 15:12
@junaruga junaruga merged commit dfc918b into cucumber:master Mar 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathieujobin mathieujobin mathieujobin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@junaruga @mathieujobin