Table#diff! not working with :surplus_row => false and interleaved surplus rows

[L2G]

Original Lighthouse ticket 566

I just ran into this bug yesterday on a work project, and I was surprised/dismayed to find it appeared to be the one lone test in Cucumber marked "pending."

Since I really want this fixed, I will take my best crack at it--but I'm still a rookie with Cucumber and RSpec, so someone with more experience may be able to do it more quickly. :-)

[L2G]

@hashrocket appears to have discovered this bug independently and done some work on it. (At least it looks related?)

https://github.com/hashrocket/cucumber/tree/failing-spec-for-surplus-rows

[mattwynne]

What's the upshot here? Is there a fix to merge in?

[adriancb]

I've attempted a fix to this at cucumber/common#347

[os97673]

It turns out that the cause of the problem was incorrect behavior of Cell class.
Namely it overrode == but didn't override hash() and this made it unusable with hashes.
Thus I've implemented hash(), eql?, and equal? and everything work ok (at least with the test provided)

[mattwynne]

Nice work Oleg!

[os97673]

Fortunately equal+hash is common problem for any language :)
But I do not like that now all Cells have the same hash code, though it is exactly what we have to have.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.