Deprecation warning from gherkin

[miketheman]

MRI 1.9.3-p385
cucumber (1.2.3)
gherkin (2.11.7)

While running

[DEPRECATION] "eval" is deprecated. Please use "evaluate" instead

appears a lot.

I found cucumber/gherkin/issues/238, but that seems to imply that the change is made in gherkin, and that the calls to the evaluate() method have not been updated in cucumber itself.

This may apply to ansicolor only, not sure.

[mattwynne]

@os97673 now the new Gherkin is out, I think it's time to make a patch release of Cucumber to match up with it.

WDYT? Have you got time to do it?

[os97673]

It looks like a good idea, I just need to check what should be fixed to make Cucumber works fine with new gherkin
(currently working on this)

[os97673]

@mattwynne do you think we have to create separate branch from v1.2.3 or it is ok to release 1.2.4 from master?

[mattwynne]

Yeah, we've been targeting 1.3 in master so my instinct would be to branch off the 1.2.3 tag, release, then merge into master.

Having said that, I can't recall any breaking changes we've made. You could check history.md and if you're confident there are no breaking changes we may as well ship it all as 1.2.4.

[os97673]

@mattwynne The only questionable change I see in History.md is #162. Do you think this can be released as 1.2.4?

[abotalov]

From semver:

Patch version Z (x.y.Z | x > 0) MUST be incremented if only backwards compatible bug fixes are introduced. A bug fix is defined as an internal change that fixes incorrect behavior.

So patch version must not contain new features according to semver

[os97673]

:( will create separate branch

[aslakhellesoy]

Only backwards compatible bug fixes are added AFAICT. So we MUST increment patch from 1.2.3 to 1.2.4 for the next release.

It's only when we change the public API that we need to increment minor from 1.2.x to 1.3.0. I can't see that we're changing any public APIs in Cucumber here.

What are the public API changes that warrant a bump of minor?

[os97673]

It is a tricky question: #162 changes contract/behavior it is not a public API, but something rather close to it.

[abotalov]

As I cited according to semver patch versions are only for "backwards compatible bug fixes".

Some changes in 1.2.4 are not backwards compatible bug fixes.

Just a note.

[aslakhellesoy]

@abotalov what changes are not backwards compatible bug fixes?

[os97673]

Some changes in 1.2.4 are not backwards compatible bug fixes.

I've already released 1.2.4 from master thus if you know changes which should not be included into it please let us know. But let's do this on our mailing list, it is not very convenient to do this here also more people will be informed.

[miketheman]

The milestone tagged in this issue is 1.3.0 - is that still correct, now that 1.2.4 is released?
Also, thanks on the awesome turnaround time on this.

[os97673]

Updated

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.