-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
html formatter marks paints wrong scenario red, when failure occurs in background step #520
Comments
mlex
added a commit
to mlex/cucumber
that referenced
this issue
Aug 16, 2013
mlex
added a commit
to mlex/cucumber
that referenced
this issue
Aug 16, 2013
…round step fails When encountering a failure in a background step, the html formatter incorrectly marked the previous scenario red. With this fix, the html formatter now correctly marks the current background red and does not touch the output of the previous scenario anymore.
mlex
added a commit
to mlex/cucumber
that referenced
this issue
Aug 16, 2013
…round step fails When encountering a failure in a background step, the html formatter incorrectly marked the previous scenario red. With this fix, the html formatter now correctly marks the current background red and does not touch the output of the previous scenario anymore.
closed by #521 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When a background-step fails, the html-formatter incorrectly paints the scenario directly above the failing background red (and not the background). This is very misleading, because the red scenario doesn't even belong to the same feature like the failed background-step.
Consider a project with 2 features, each having a background and 2 scenarios:
If a step in feature-B-background fails, then feature-A-scenario-2 will be marked as a failure (red background). Instead the feature-B-background should have a red background.
The problem is, that in methods set_scenario_color_failed (resp. set_scenario_color_pending) in https://github.com/cucumber/cucumber/blob/master/lib/cucumber/formatter/html.rb#L422 the scenario_#number is painted red (resp. yellow). If the current step is a background step, the element 'background_#number' should be painted red (resp. yellow) instead.
I'm working on a test-case and bugfix.
The text was updated successfully, but these errors were encountered: