-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spec: Events.registry exercised #1126
Conversation
The warning fixes should be split out to a separate PR, especially since the choice of not to use parenthesis is very deliberate. |
@brasmussen Thanks for the feedback! I agree that splitting this makes sense, and I'll get to it in a few days. Thanks also for linking to discussions. It makes it possible to learn the why of things. |
3504c66
to
696757e
Compare
696757e
to
add9918
Compare
The JRuby test fails on both 9.1.10.0 and on 9.1.12.0 on this feature:
|
@olleolleolle that could just be a flicker. The JRuby tests can be really slow. Can you try triggering a rebuild? |
I can do that, again. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR adds a unit test which calls the method
Events.registry
, in order to exercise the code. See #1124Eh, also: work to get rid of all the Ruby warnings, to prepare to enable
--warnings
in.rspec
.