Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec: Events.registry exercised #1126

Merged
merged 1 commit into from
Jul 7, 2017

Conversation

olleolleolle
Copy link
Contributor

@olleolleolle olleolleolle commented Jun 22, 2017

This PR adds a unit test which calls the method Events.registry, in order to exercise the code. See #1124


Eh, also: work to get rid of all the Ruby warnings, to prepare to enable --warnings in .rspec.

@brasmusson
Copy link
Contributor

The warning fixes should be split out to a separate PR, especially since the choice of not to use parenthesis is very deliberate.

@olleolleolle
Copy link
Contributor Author

@brasmussen Thanks for the feedback! I agree that splitting this makes sense, and I'll get to it in a few days.

Thanks also for linking to discussions. It makes it possible to learn the why of things.

@olleolleolle olleolleolle force-pushed the feature/add-basic-events-unit-test branch 2 times, most recently from 3504c66 to 696757e Compare June 24, 2017 10:45
@olleolleolle olleolleolle force-pushed the feature/add-basic-events-unit-test branch from 696757e to add9918 Compare June 24, 2017 10:47
@olleolleolle
Copy link
Contributor Author

olleolleolle commented Jun 24, 2017

The JRuby test fails on both 9.1.10.0 and on 9.1.12.0 on this feature:

(::) failed steps (::)
process still alive after 60 seconds (ChildProcess::TimeoutError)
features/docs/raketask.feature:38:in `When I run `bundle exec rake pass`'

process still alive after 60 seconds (ChildProcess::TimeoutError)
features/docs/raketask.feature:42:in `When I run `bundle exec rake fail`'

Failing Scenarios:
  cucumber -p ruby features/docs/raketask.feature:37 # Scenario: Passing feature
  cucumber -p ruby features/docs/raketask.feature:41 # Scenario: Failing feature

208 scenarios (2 failed, 206 passed)

master is building the other code.

@mattwynne
Copy link
Member

@olleolleolle that could just be a flicker. The JRuby tests can be really slow. Can you try triggering a rebuild?

@olleolleolle
Copy link
Contributor Author

I can do that, again.

@mattwynne mattwynne merged commit a9134fe into master Jul 7, 2017
@olleolleolle olleolleolle deleted the feature/add-basic-events-unit-test branch July 8, 2017 10:09
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants