Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle selective strict options. #1169

Merged
merged 1 commit into from
Aug 6, 2017
Merged

Conversation

brasmusson
Copy link
Contributor

Summary

Let the result types affected the the strict settings be controlled individually, so only a subset of the can be set to be handled strict.

Details

Add the options

  • --[no-]strict-undefined,
  • --[no-]strict-pending, and
  • --[no-]strict-flaky,

so each of the result type affected by the strict settings be controlled individually.
The --[no-]strict option is equivalent to --[no-]strict-undefined --[no-]strict-pending --[no-]strict-flaky.
Also make sure that it is possible from the command line to adjust the strict setting from a profile, for instance:
Given that a profile includes the --strict option
When using --no-strict-flaky on the command line
Then only undefined and pending will be handled strict

Depends on cucumber/cucumber-ruby-core#143.

Motivation and Context

Fixes #1160.

How Has This Been Tested?

The automated test suite has been updated to verify this behaviour.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly (the --help option will describe the new options).

Add the options --[no-]strict-undefined, --[no-]strict-pending, and
--[no-]strict-flaky, so each of the result type affected by the strict
settings be controlled individually.
@streetlogics
Copy link

@brasmusson Thanks for this! Plugged it in and works like a charm.

@brasmusson brasmusson merged commit dfef67d into master Aug 6, 2017
brasmusson added a commit that referenced this pull request Aug 6, 2017
@brasmusson brasmusson deleted the selective-strict-option branch August 6, 2017 19:28
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cucumber --retry option status 1 with strict mode causes --retry option to not be useful
2 participants