Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ParameterType transformer runs in World #1213

Merged
merged 2 commits into from
Nov 28, 2017
Merged

ParameterType transformer runs in World #1213

merged 2 commits into from
Nov 28, 2017

Conversation

aslakhellesoy
Copy link
Contributor

Summary

Allow transformer lambdas to delegate to World

Motivation and Context

Because sometimes we need stuff from the world to transform a string to a "rich" object

How Has This Been Tested?

Unit tests in cucumber-expressions, new scenario in this PR

Types of changes

  • Refactor (code change that does not change external functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@ghost ghost assigned aslakhellesoy Oct 11, 2017
@aslakhellesoy aslakhellesoy merged commit 6742a2e into master Nov 28, 2017
aslakhellesoy added a commit that referenced this pull request Nov 28, 2017
@aslakhellesoy
Attribution for #1213
5f35029
@dependabot-preview dependabot-preview bot mentioned this pull request Mar 20, 2018
Closed
@aslakhellesoy aslakhellesoy mentioned this pull request Sep 12, 2018
Closed
@lock
Copy link

lock bot commented Nov 28, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 28, 2018
@luke-hill luke-hill deleted the parameter-type-transform-runs-in-world branch February 14, 2019 15:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@aslakhellesoy aslakhellesoy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aslakhellesoy