Update code to include env files in dry run

[danascheider]

Summary

Causes Cucumber to load env.rb files even on dry run.

Details

This PR removes a conditional in configuration.rb that prevents env files from loading when the --dry-run option is turned on. It also updates the help message for --dry-run to omit the part about env files not loading.

Motivation and Context

In #1324, @dpsi brings up an issue they're having loading constants and libraries when Cucumber runs under the --dry-run option, pointing out that this is not the first time users have brought up this problem with us. The issue stems from the env.rb files not being loaded.

How Has This Been Tested?

The test ensuring that env files are not loaded on dry runs has been removed. I've ensured that env files do still load first in all cases.

Types of changes

• Refactor (code change that does not change external functionality)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• I've added tests for my code
• My change requires a change to the documentation.
• I have updated the documentation accordingly.

[danascheider]

@mattwynne I also just noticed that CircleCI sent me an e-mail saying my access was revoked. Do you know why that could be?

[aslakhellesoy]

Please hold off on merging this until we’ve agreed on the purpose of a dry run. I have reopened #1324 - let’s continue the discussion there.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.