Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow attaching path #1514

Merged
merged 13 commits into from
Apr 2, 2021
Merged

Allow attaching path #1514

merged 13 commits into from
Apr 2, 2021

Conversation

aurelien-reeves
Copy link
Contributor

Is your pull request related to a problem? Please describe.

Fixes #1506

Describe the solution you have implemented

We plan to allow attaching files by specifying their path
Cucumber will take care of opening and reading it.

@luke-hill
Copy link
Contributor

Make sure to add a path to a file auto-detects (Maybe based off extension??)

You could have an outline with

foo.png
bar.txt
baz.md
bay.jpeg

e.t.c.

@aurelien-reeves
Copy link
Contributor Author

Make sure to add a path to a file auto-detects (Maybe based off extension??)

You could have an outline with

foo.png
bar.txt
baz.md
bay.jpeg

e.t.c.

Yeah, that is interesting indeed 👍
At first I'll push a basic feature file with no auto-detection specified for a first iteration. Once it passes, we will be able to iterate on that auto-detection ideas

Add two scenarios in it, one using messages, and the other one using a
json formatter.

Indeed the json formatter already implement the desired behavior, so it
is interesting to have a failing test for what we will implement, and a
passing test for what already exists.
@aslakhellesoy
Copy link
Contributor

This looks great @aurelien-reeves! Nice and simple.

Reading your code I had an idea that we might be able to add at the same time: Make the media type optional when you're passing an existing path. We could use a library to look up a media type for a file extension.

@aurelien-reeves aurelien-reeves marked this pull request as ready for review March 31, 2021 15:35
@aurelien-reeves aurelien-reeves merged commit 757f1b2 into master Apr 2, 2021
@mattwynne mattwynne deleted the allow-attaching-path branch May 1, 2021 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow attaching a path
4 participants