-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow attaching path #1514
Allow attaching path #1514
Conversation
Make sure to add a path to a file auto-detects (Maybe based off extension??) You could have an outline with
e.t.c. |
Yeah, that is interesting indeed 👍 |
Add two scenarios in it, one using messages, and the other one using a json formatter. Indeed the json formatter already implement the desired behavior, so it is interesting to have a failing test for what we will implement, and a passing test for what already exists.
This looks great @aurelien-reeves! Nice and simple. Reading your code I had an idea that we might be able to add at the same time: Make the media type optional when you're passing an existing path. We could use a library to look up a media type for a file extension. |
Is your pull request related to a problem? Please describe.
Fixes #1506
Describe the solution you have implemented
We plan to allow attaching files by specifying their path
Cucumber will take care of opening and reading it.