Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show class name of exceptions in the HTML formatter #159

Merged
merged 1 commit into from
Nov 19, 2011

Conversation

jarib
Copy link
Contributor

@jarib jarib commented Oct 21, 2011

Sometimes the exception class name is useful, and they're already printed when running from the command line.

I've ignored RuntimeError - we could ignore others as well (perhaps RSpec::Expectations::ExpectationNotMetError).

I couldn't figure out how/if you're testing the HTML formatter at the moment (the legacy feature appears to be failing without my change), but bundle exec rake passed for me.

@mattwynne
Copy link
Member

@jarib the html formatter is well tested with specs.

On 21 Oct 2011, at 15:34, Jari Bakken wrote:

Sometimes the exception class name is useful, and they're already printed when running from the command line.

I've ignored RuntimeError - we could ignore others as well (perhaps RSpec::Expectations::ExpectationNotMetError).

I couldn't figure out how/if you're testing the HTML formatter at the moment (the legacy feature appears to be failing without my change), but bundle exec rake passed for me.

You can merge this Pull Request by running:

git pull https://github.com/jarib/cucumber master

Or you can view, comment on it, or merge it online at:

cucumber/common#159

-- Commit Summary --

  • Show the class name of exceptions in the HTML formatter.

-- File Changes --

M lib/cucumber/formatter/html.rb (5)

-- Patch Links --

https://github.com/cucumber/cucumber/pull/159.patch
https://github.com/cucumber/cucumber/pull/159.diff

Reply to this email directly or view it on GitHub:
cucumber/common#159

cheers,
Matt

Freelance programmer & coach
Author, http://pragprog.com/book/hwcuc/the-cucumber-book (with Aslak Hellesøy)
Founder, http://relishapp.com
+44(0)7974430184 | http://twitter.com/mattwynne

@aslakhellesoy aslakhellesoy merged commit d2326c4 into cucumber:master Nov 19, 2011
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants