Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use i18n on Gherkin::Parser::Parser #433

Merged
merged 2 commits into from
Apr 12, 2013

Conversation

eiel
Copy link
Contributor

@eiel eiel commented Apr 10, 2013

I want to write steps in used language.

前提 /^foo$/ do
  steps %{
    前提 bar
    前提 bar
  }
end

this modified depend on cucumber/gherkin#229

@mattwynne
Copy link
Member

Thanks! This will fix #149 I believe.

@mattwynne
Copy link
Member

Sorry, I mean arigatou gozaimashita!

@eiel
Copy link
Contributor Author

eiel commented Apr 10, 2013

Sorry, I mean arigatou gozaimashita!

👍

@eiel
Copy link
Contributor Author

eiel commented Apr 10, 2013

A test fails in ruby 1.8.
Although it is because there is while the method of Japanese like 前提 codes this, the idea which I avoid does not appear.

Aren't there any good ideas?

@eiel
Copy link
Contributor Author

eiel commented Apr 10, 2013

I added tag @fails_ruby_1_8_7

mattwynne added a commit that referenced this pull request Apr 12, 2013
Use i18n on Gherkin::Parser::Parser
@mattwynne mattwynne merged commit a81b83e into cucumber:master Apr 12, 2013
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants