map_headers refactored #528
Conversation
|
Looks good, thanks @adbatista. Do you think we should support the same api as #map_headers! and allow the user to pass a block as the new header_conversion_proc? That can also be passed to the constructor. |
|
I was thinking about that, and since map_headers! will be deprecated, I think it's a good idea allow the user pass a block to |
|
I added block to |
| table.map_headers!(mappings) | ||
| table | ||
| def map_headers(mappings={}, &block) | ||
| Table.new raw.dup, @conversion_procs.dup, mappings, block |
There was a problem hiding this comment.
@adbatista I think it would be safest if this called self.class.new just in case someone is subclassing AST::Table
ghost
assigned 
|
@adbatista thanks, appreciate your efforts on this. |
|
Nice, my first Open source contribution. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
I refactored
map_headers