Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splat arguments to NoStepMatch#format_args to avoid "wrong number of arguments (0 for 1) (ArgumentError)" #587

Merged

Conversation

jshraibman-mdsol
Copy link
Contributor

Alternate to PR #581, which is against master. This is against v1.3.x-bugfix

Test regression

[jshraibman@Joseph-Shraibmans-MacBook-Pro fix/bilgerat_issue_1/1.3bugfix ~/work/cucumber]$ ber
/Users/jshraibman/.rvm/rubies/ruby-1.9.3-p448/bin/ruby -S rspec ./spec/cucumber/ast/background_spec.rb ./spec/cucumber/ast/doc_string_spec.rb ./spec/cucumber/ast/feature_spec.rb ./spec/cucumber/ast/features_spec.rb ./spec/cucumber/ast/outline_table_spec.rb ./spec/cucumber/ast/scenario_outline_spec.rb ./spec/cucumber/ast/step_spec.rb ./spec/cucumber/ast/table_spec.rb ./spec/cucumber/ast/tree_walker_spec.rb ./spec/cucumber/broadcaster_spec.rb ./spec/cucumber/cli/configuration_spec.rb ./spec/cucumber/cli/drb_client_spec.rb ./spec/cucumber/cli/main_spec.rb ./spec/cucumber/cli/options_spec.rb ./spec/cucumber/cli/profile_loader_spec.rb ./spec/cucumber/configuration_spec.rb ./spec/cucumber/constantize_spec.rb ./spec/cucumber/core_ext/proc_spec.rb ./spec/cucumber/formatter/ansicolor_spec.rb ./spec/cucumber/formatter/duration_spec.rb ./spec/cucumber/formatter/html_spec.rb ./spec/cucumber/formatter/interceptor_spec.rb ./spec/cucumber/formatter/junit_spec.rb ./spec/cucumber/formatter/pretty_spec.rb ./spec/cucumber/formatter/progress_spec.rb ./spec/cucumber/rake/forked_spec.rb ./spec/cucumber/rake/rcov_spec.rb ./spec/cucumber/rb_support/rb_language_spec.rb ./spec/cucumber/rb_support/rb_step_definition_spec.rb ./spec/cucumber/rb_support/rb_transform_spec.rb ./spec/cucumber/rb_support/regexp_argument_matcher_spec.rb ./spec/cucumber/rb_support/snippet_spec.rb ./spec/cucumber/runtime/for_programming_languages_spec.rb ./spec/cucumber/runtime/results_spec.rb ./spec/cucumber/runtime/support_code_spec.rb ./spec/cucumber/runtime_spec.rb ./spec/cucumber/step_match_spec.rb ./spec/cucumber/wire_support/configuration_spec.rb ./spec/cucumber/wire_support/connection_spec.rb ./spec/cucumber/wire_support/wire_exception_spec.rb ./spec/cucumber/wire_support/wire_language_spec.rb ./spec/cucumber/wire_support/wire_packet_spec.rb ./spec/cucumber/wire_support/wire_step_definition_spec.rb ./spec/cucumber/world/pending_spec.rb
............................................................................................................................................................Spork is no longer supported as of Cucumber 1.3.0. Please downgrade to version 1.2.5
.Spork is no longer supported as of Cucumber 1.3.0. Please downgrade to version 1.2.5
.Spork is no longer supported as of Cucumber 1.3.0. Please downgrade to version 1.2.5
.Spork is no longer supported as of Cucumber 1.3.0. Please downgrade to version 1.2.5
.....................................................................................................................................................................................................................................................................................

Finished in 1.62 seconds
436 examples, 0 failures
/Users/jshraibman/.rvm/rubies/ruby-1.9.3-p448/bin/ruby -S bundle exec cucumber  --profile ruby_1_9
Using the ruby_1_9 profile...
...........................................................................................................   t..................................................................Using Cucumber, Unknown
Loading Spork.prefork block...
I'm loading all the heavy stuff...
Spork is ready and listening on 8990!
.Running tests with args ["features/sample.feature", "-r", "features", "--tags", "~@wip", "--format", "pretty", "--strict", "--tags", "~@wip", "--no-profile"]...
Done.

.......Using Cucumber, Unknown
Loading Spork.prefork block...
I'm loading all the heavy stuff...
Spork is ready and listening on 8990!
.Running tests with args ["features/sample.feature", "--tags", "~@wip", "--format", "pretty", "--strict", "--tags", "~@wip", "--no-profile"]...
Done.

................................----........................................................................................................................................................................................................

67 scenarios (67 passed)
394 steps (394 passed)
0m15.211s
/Users/jshraibman/.rvm/rubies/ruby-1.9.3-p448/bin/ruby -S bundle exec cucumber  --profile legacy
Using the legacy profile...
..............................................................................................................................................................................................................................................................................................................................................................---..................----.............................................................................................................................................................................................................................................................................................

119 scenarios (119 passed)
635 steps (635 passed)
1m17.426s

tooky added a commit that referenced this pull request Nov 6, 2013
…3bugfix

Splat arguments to NoStepMatch#format_args to avoid "wrong number of arguments (0 for 1) (ArgumentError)"
@tooky tooky merged commit 5b4ab4d into cucumber:v1.3.x-bugfix Nov 6, 2013
@tooky
Copy link
Member

tooky commented Nov 6, 2013

thanks @jshraibman-mdsol

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants