Let the rerun formatter includes all scenarios when the background fails (v1.3.x) #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let the rerun formatter includes all scenarios in the feature if the background fails. It is realized by changing the rerun formatter to also include skipped scenarios.
|
LGTM, thanks @brasmusson. @os97673 can you merge this and do a release? |
os97673
added a commit
that referenced
this pull request
Mar 25, 2014
Let the rerun formatter includes all scenarios when the background fails (v1.3.x)
|
@mattwynne I can merge and I will try to release tonight (just moved to a new laptop and need to configure it first ;) |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #650 and #653 the rerun formatter only includes the first scenario when (a step in) the background fails. The root cause of this is that Cucumber v1.3.x skips the rest of the scenarios of the feature in this case.
Let the rerun formatter includes all scenarios in the feature if the background fails. It is realized by changing the rerun formatter to also include skipped scenarios.