wip-new-core: Fix embedding for the JSON formatter output #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The legacy_formatter need to make sure that the embed calls from the step definitions are not passed to the formatter until it got information about the corresponding step.
If the scenario is not @Spawn:ed the scenario: " features/docs/gherkin/background.feature:346 # Scenario: run a feature with a background that is pending" fails in the JRuby build on Travis (due to that a full error backtrace is emitted, so it seems that the -b flag is carried over somehow).
|
Good work! You're quite right: the main job of the |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In legacy_formatter calls to embed is passed on directly to the formatters. This means that they will arrive to the formatter "out of order" - before the formatter knows which the corresponding step is.
It is possible to make the JSON formatter able to handle such "out of order" calls to embed, but I think it is the responsibility of legacy_formatter not to make such a major change to the call sequence the formatter experience. Therefore the calls to embed from the step definitions is delayed in legacy_formatter until the formatter has been informed of the corresponding step.