-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add an initial feature for rerunning failing tests #895
Conversation
Then it should pass with: | ||
""" | ||
Feature: Fails | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe a @flaky
tag here?
Suggest we call it retry rather than rerun since rerun already has a meaning in our domain (the rerun formatter) |
- Output rerun information in test report | ||
|
||
Questions: | ||
use a tag for flaky tests? Global option to rerun any test that fails? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're going to reproduce the Maven behaviour (which is what I suggest we start with) then we should just have a global option.
One concern I have for you with this is that there may be some yak-shaving to do in order to meddle around with how the summary results like |
Thanks @mattwynne I'll take a look. I won't spend much time on the output here, but the global option to run with retries for any failures makes sense. |
Superseded by #920 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
I'm taking a crack at implementing #882 with the outline/example from Maven reruns
I thought that one particular example would be that you could get a pass out of this, but you should still see the error information.
I like the idea as a way to help get through a tough spot, but living with flaky tests should hurt a little bit 😄
I would love to get to adding some code if this is close to what people were looking for out of this enhancement.
What do you think @mattwynne ?