Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an initial feature for rerunning failing tests #895

Closed
wants to merge 1 commit into from

Conversation

richarda
Copy link
Contributor

I'm taking a crack at implementing #882 with the outline/example from Maven reruns

I thought that one particular example would be that you could get a pass out of this, but you should still see the error information.

I like the idea as a way to help get through a tough spot, but living with flaky tests should hurt a little bit 😄

I would love to get to adding some code if this is close to what people were looking for out of this enhancement.

What do you think @mattwynne ?

Then it should pass with:
"""
Feature: Fails

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a @flaky tag here?

@mattwynne mattwynne added the WIP label Aug 7, 2015
@mattwynne
Copy link
Member

Suggest we call it retry rather than rerun since rerun already has a meaning in our domain (the rerun formatter)

- Output rerun information in test report

Questions:
use a tag for flaky tests? Global option to rerun any test that fails?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're going to reproduce the Maven behaviour (which is what I suggest we start with) then we should just have a global option.

@mattwynne
Copy link
Member

One concern I have for you with this is that there may be some yak-shaving to do in order to meddle around with how the summary results like (1 passed, 1 flake) are printed. Currently that code is pretty ugly and old, and has almost reached the top of my refactoring list. It might be sensible to do that first on master. But you could get on with figuring out how to do the retries, in any case.

@mattwynne mattwynne added this to the 3.0 milestone Aug 7, 2015
@richarda
Copy link
Contributor Author

Thanks @mattwynne I'll take a look. I won't spend much time on the output here, but the global option to run with retries for any failures makes sense.

@mattwynne
Copy link
Member

Superseded by #920

@mattwynne mattwynne closed this Apr 19, 2016
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants