Correct grammatical mistake #914
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danascheider
added a commit
to danascheider/cucumber-ruby
that referenced
this pull request
Oct 19, 2015
Add retry_attempts method to configuration base class Add Retry formatter and specs for same Remove files attempting to implement --retry with a formatter - bad idea Add wip tag to prevent --retry features from killing the build Actually run Travis build against active branch Fix tiny grammatical error. Closes cucumber#914.
brasmusson
pushed a commit
that referenced
this pull request
Mar 20, 2016
Add retry_attempts method to configuration base class Add Retry formatter and specs for same Remove files attempting to implement --retry with a formatter - bad idea Add wip tag to prevent --retry features from killing the build Actually run Travis build against active branch Fix tiny grammatical error. Closes #914.
danascheider
added a commit
to danascheider/cucumber-ruby
that referenced
this pull request
May 12, 2016
Add retry_attempts method to configuration base class Add Retry formatter and specs for same Remove files attempting to implement --retry with a formatter - bad idea Add wip tag to prevent --retry features from killing the build Actually run Travis build against active branch Fix tiny grammatical error. Closes cucumber#914.
mattwynne
pushed a commit
that referenced
this pull request
May 17, 2016
* Add feature file from PR 895 to start work on retry functionality * Initial spec for --retry option * Add another test for --retry flag, make new tests pass * Squash some commits Redo the commit I just reverted but with the file I intended to include the first time * Rebase onto master * Allow for --retry option in configuration Add retry_attempts method to configuration base class Add Retry formatter and specs for same Remove files attempting to implement --retry with a formatter - bad idea Add wip tag to prevent --retry features from killing the build Actually run Travis build against active branch Fix tiny grammatical error. Closes #914. * Update scenarios to look like @mattwynne's suggestion * Initial specs for retry filter - they test if it works at all, basically Change Retry filter to have attribute :configuration and first pass at setting up a listener Reorganize spec file Finish adding tests for re-running flaky test cases - all but one pass Fix spec that said to test what happens when a test case passes but actually didn't make sure it did pass * Add consistently failing scenario to test cases Define steps for the retry feature * Correct # of retries * Refactor test case * Make method private * Extract retry_required? method * Move steps for retry filter into other file * Correct block style
richarda
pushed a commit
to richarda/cucumber
that referenced
this pull request
Jul 1, 2016
…umber#920) * Add feature file from PR 895 to start work on retry functionality * Initial spec for --retry option * Add another test for --retry flag, make new tests pass * Squash some commits Redo the commit I just reverted but with the file I intended to include the first time * Rebase onto master * Allow for --retry option in configuration Add retry_attempts method to configuration base class Add Retry formatter and specs for same Remove files attempting to implement --retry with a formatter - bad idea Add wip tag to prevent --retry features from killing the build Actually run Travis build against active branch Fix tiny grammatical error. Closes cucumber#914. * Update scenarios to look like @mattwynne's suggestion * Initial specs for retry filter - they test if it works at all, basically Change Retry filter to have attribute :configuration and first pass at setting up a listener Reorganize spec file Finish adding tests for re-running flaky test cases - all but one pass Fix spec that said to test what happens when a test case passes but actually didn't make sure it did pass * Add consistently failing scenario to test cases Define steps for the retry feature * Correct # of retries * Refactor test case * Make method private * Extract retry_required? method * Move steps for retry filter into other file * Correct block style
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is incredibly minor and mundane, but I went ahead and changed the past tense to the past participle in here. What can I say, I have too much time on my hands.