stringifying location for more consistent json parsing - address #945 #949
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started running into issues when formatting cucumber reports as JSON. With the default JSON gem (also I believe 'oj' and 'yajl'), it seems that the JSON formatter has started stringifying the
location
object on steps as hashes instead of using theto_s
method found in cucumber-ruby-core.Desired Output:
Undesired Output:
This issue does not occur when running the spec tests using the
json_spec
gem, but happens every time with the classic ruby JSON gem (1.8.3). I added ato_s
call when creating the match hash, which doesn't seem to have any other repercussions besides fixing this bug.Fixes #945.