Skip to content

Commit

Permalink
[Ruby]: Ruby / Messages bump (#165)
Browse files Browse the repository at this point in the history
* minimum ruby version is now 2.5

* Bump minimum version of messages

* Update test ruby workflow

* Release using ruby 3.2

* Update messages to use v22

* Add changelog note about minimum ruby bump

* [noci]: Simplify changelog

* Relax messages requirement

* Fix workflow bug where ruby tests weren't running correctly

* Minimize diff

* Minimize diff

* Minimize diff

* Minimize diff

* Fix missing changelog entry

---------

Co-authored-by: M.P. Korstanje <[email protected]>
  • Loading branch information
luke-hill and mpkorstanje authored Sep 12, 2023
1 parent a610d1b commit 9739c0d
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 15 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/release-rubygem.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4
- uses: ruby/setup-ruby@v1
with:
ruby-version: '3.0.2'
ruby-version: '3.2'
bundler-cache: true
- uses: cucumber/[email protected]
with:
Expand Down
13 changes: 5 additions & 8 deletions .github/workflows/test-ruby.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,14 @@ jobs:
matrix:
os:
- ubuntu-latest
ruby: ["2.6", "2.7", "3.0", "3.1"]
ruby: ['2.6', '2.7', '3.0', '3.1', '3.2']
include:
- os: macos-latest
ruby: "3.1"
ruby: '3.2'

steps:
- uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4

- name: Set up Ruby
uses: ruby/setup-ruby@v1
- uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
bundler-cache: true
Expand All @@ -42,6 +40,5 @@ jobs:
- run: bundle exec rake
working-directory: ruby

- name: run acceptance tests
run: make acceptance
working-directory: ruby
- run: make acceptance
working-directory: ruby
8 changes: 4 additions & 4 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@ This document is formatted according to the principles of [Keep A CHANGELOG](htt

## [Unreleased]
### Changed
- [.NET] Bump sdk to .net 8. Added .net 8 to test platforms.
- [Go] Upgraded messages to v22
- [.NET] Bump sdk to .net 8. Added .net 8 to test platforms
- [Go, Perl, Ruby] Upgraded messages to v22
- [Go] Improve performance - don't compile regex on matcher create
- [Perl] Fix release packaging
- [Perl] Include CHANGELOG.md in tarball
- [Perl] Upgrade messages to v22
- [Perl] Harmonized error reporting with mainstream implementations errors are now converted to messages and reported in the message stream ([#31](https://github.com/cucumber/gherkin/issues/31))
- [Perl] Harmonized error reporting with mainstream implementations - errors are now converted to messages and reported in the message stream ([#31](https://github.com/cucumber/gherkin/issues/31))
- [Ruby] Update minimum ruby requirement from 2.3 to 2.5

### Added
- (i18n) Added Malayalam localization
Expand Down
4 changes: 2 additions & 2 deletions ruby/cucumber-gherkin.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Gem::Specification.new do |s|
s.homepage = 'https://github.com/cucumber/gherkin'
s.platform = Gem::Platform::RUBY
s.license = 'MIT'
s.required_ruby_version = '>= 2.3'
s.required_ruby_version = '>= 2.5'

s.metadata = {
'bug_tracker_uri' => 'https://github.com/cucumber/gherkin/issues',
Expand All @@ -20,7 +20,7 @@ Gem::Specification.new do |s|
'source_code_uri' => 'https://github.com/cucumber/gherkin/blob/main/ruby'
}

s.add_runtime_dependency 'cucumber-messages', '>= 19.1.4', '< 22.1'
s.add_runtime_dependency 'cucumber-messages', '>= 19.1.4', '< 23'

s.add_development_dependency 'rake', '~> 13.0', '>= 13.0.6'
s.add_development_dependency 'rspec', '~> 3.11', '>= 3.11.0'
Expand Down

0 comments on commit 9739c0d

Please sign in to comment.