Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ruby]: Ruby / Messages bump #165

Merged
merged 16 commits into from
Sep 12, 2023
Merged

[Ruby]: Ruby / Messages bump #165

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
088ba41
minimum ruby version is now 2.5
luke-hill Sep 7, 2023
c3d8f02
Bump minimum version of messages
luke-hill Sep 7, 2023
7189012
Update test ruby workflow
luke-hill Sep 7, 2023
8e48bbc
Release using ruby 3.2
luke-hill Sep 7, 2023
662a09c
Update messages to use v22
luke-hill Sep 7, 2023
fa33a6f
Add changelog note about minimum ruby bump
luke-hill Sep 7, 2023
06cdb30
[noci]: Simplify changelog
luke-hill Sep 7, 2023
2b0d261
Relax messages requirement
luke-hill Sep 8, 2023
4f589d3
Merge branch 'main' into refactor/minimum_ruby_bump
luke-hill Sep 8, 2023
6f03781
Fix workflow bug where ruby tests weren't running correctly
luke-hill Sep 8, 2023
d95c74c
Merge remote-tracking branch 'origin/main' into refactor/minimum_ruby…
mpkorstanje Sep 9, 2023
718e60a
Minimize diff
mpkorstanje Sep 9, 2023
326ad17
Minimize diff
mpkorstanje Sep 9, 2023
c17bc91
Minimize diff
mpkorstanje Sep 9, 2023
99f5f60
Minimize diff
mpkorstanje Sep 9, 2023
65e36f1
Fix missing changelog entry
luke-hill Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release-rubygem.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4
- uses: ruby/setup-ruby@v1
with:
ruby-version: '3.0.2'
ruby-version: '3.2'
bundler-cache: true
- uses: cucumber/[email protected]
with:
Expand Down
13 changes: 5 additions & 8 deletions .github/workflows/test-ruby.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,14 @@ jobs:
matrix:
os:
- ubuntu-latest
ruby: ["2.6", "2.7", "3.0", "3.1"]
ruby: ['2.6', '2.7', '3.0', '3.1', '3.2']
include:
- os: macos-latest
ruby: "3.1"
ruby: '3.2'

steps:
- uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4

- name: Set up Ruby
uses: ruby/setup-ruby@v1
- uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
bundler-cache: true
Expand All @@ -36,6 +34,5 @@ jobs:
- run: bundle exec rake
working-directory: ruby

- name: run acceptance tests
run: make acceptance
working-directory: ruby
- run: make acceptance
working-directory: ruby
4 changes: 2 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@ This document is formatted according to the principles of [Keep A CHANGELOG](htt

## [Unreleased]
### Changed
- [Go] Upgraded messages to v22
- [Go, Ruby, Perl] Upgraded messages to v22
- [Go] Improve performance - don't compile regex on matcher create
- [Perl] Fix release packaging
- [Perl] Include CHANGELOG.md in tarball
- [Perl] Upgrade messages to v22
- [Perl] Harmonized error reporting with mainstream implementations;
errors are now converted to messages and reported in the message stream
([#31](https://github.com/cucumber/gherkin/issues/31))
mpkorstanje marked this conversation as resolved.
Show resolved Hide resolved
- [Ruby] Update minimum ruby requirement from 2.3 to 2.5

### Added
- (i18n) Add Malayalam localization
Expand Down
1 change: 1 addition & 0 deletions ruby/Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# frozen_string_literal: true

source "https://rubygems.org"

gemspec
4 changes: 2 additions & 2 deletions ruby/cucumber-gherkin.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Gem::Specification.new do |s|
s.homepage = 'https://github.com/cucumber/gherkin'
s.platform = Gem::Platform::RUBY
s.license = 'MIT'
s.required_ruby_version = '>= 2.3'
s.required_ruby_version = '>= 2.5'

s.metadata = {
'bug_tracker_uri' => 'https://github.com/cucumber/gherkin/issues',
Expand All @@ -20,7 +20,7 @@ Gem::Specification.new do |s|
'source_code_uri' => 'https://github.com/cucumber/gherkin/blob/main/ruby'
}

s.add_runtime_dependency 'cucumber-messages', '>= 19.1.4', '< 22.1'
s.add_runtime_dependency 'cucumber-messages', '~> 22.0'
Copy link
Contributor

@mpkorstanje mpkorstanje Sep 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As nothing materially changed about the messages for Gherkin, is there a reason not to increase the upper bound instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As in permit 19.1 but increase the upper limit to say 23?

Currently the maximum version is 22.0 so any revision in the 22.x should be fine here. Just trying to reduce the support surface area. In theory we could keep this support area the same?

Copy link
Contributor

@mpkorstanje mpkorstanje Sep 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Allowing a wider range allows us to make major releases of messages without also making major releases of Gherkin.

This reduces the churn somewhat. Wouldn't worry about supported version ranges here. If something Gherkin related gets added to messages we'll have to use it in all Gherkin implementations (because of the single test suite).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean in theory nothing stops us from setting the upper limit to 30 by the same logic. Or having no upper limit.

Bundler flags things without an upper limit hence the twiddle key. In theory something could come in v23 which breaks things hence setting this value?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I would think '>= 19.1.4', '< 23' should be good.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make that change now.


s.add_development_dependency 'rake', '~> 13.0', '>= 13.0.6'
s.add_development_dependency 'rspec', '~> 3.11', '>= 3.11.0'
Expand Down