Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ruby] Refactor/gherkin autofix cops #266

Merged
merged 38 commits into from
Sep 16, 2024
Merged

[Ruby] Refactor/gherkin autofix cops #266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
af0fbad
Autofix and manual tidy ups of token_formatter_builder with Layout/Al…
luke-hill Aug 12, 2024
0b5004a
AF: Layout/ClosingParenthesisLocation
luke-hill Aug 12, 2024
428d3ef
AF: Layout/ReturnHaveExtraLine
luke-hill Aug 12, 2024
94e73ef
AF: Layout/SpaceAroundAttributeAccessors
luke-hill Aug 15, 2024
a6e91db
Disable naming cop not being prevented by config generator
luke-hill Aug 15, 2024
9eb8c17
AF: EmptyLinesAroundClassBody
luke-hill Aug 15, 2024
b19dba0
AF All remaining EmptyLine cops
luke-hill Aug 15, 2024
e7193de
AF: Indentation
luke-hill Aug 15, 2024
2c2639d
AF: All SpaceAround cops
luke-hill Aug 15, 2024
620f55c
AF: All Space inside cops
luke-hill Aug 15, 2024
91f561f
AF: Style/RexcuedExceptionVariableName
luke-hill Aug 15, 2024
cc0215c
AF: Style/GlobalStdInStream
luke-hill Aug 15, 2024
a6192b8
AF: MethodCallWithRedundantParens
luke-hill Aug 15, 2024
f017776
AF: Style/ParenthesesAroundCondition
luke-hill Aug 15, 2024
fb8c9ca
Re-generate TODO file
luke-hill Aug 15, 2024
283d8f3
Manual fixes for bin script
luke-hill Aug 15, 2024
0d9d39c
Add changelog entry
luke-hill Aug 15, 2024
024cb7b
Remove changes made to parser.rb
luke-hill Aug 22, 2024
763ad78
Regen config pending parser fixes
luke-hill Aug 22, 2024
3938978
AF 2 different Layout Indentation cops
luke-hill Aug 22, 2024
2c92b2b
AF: Layout/LeadingCommentSpace
luke-hill Aug 22, 2024
f094e96
Fix up Lint/NonLocalExitFromIterator
luke-hill Aug 22, 2024
35d7d67
Fix up Lint/UselessAccessModifier
luke-hill Aug 22, 2024
fabec63
Fix up name of param inside yielding method
luke-hill Aug 22, 2024
9c7e8ba
Fix up conditional assignment issue in bin package
luke-hill Aug 22, 2024
cf2334e
AF: IfUnlessModifier
luke-hill Aug 22, 2024
289185b
AF: Style/NegatedIf
luke-hill Aug 22, 2024
393dd67
AF Style/Regex
luke-hill Aug 22, 2024
109d57d
AF: RedundantReturn partially
luke-hill Aug 22, 2024
dfc8874
Partial Autofix for some files of Style/StringLiterals
luke-hill Aug 22, 2024
1945631
Partial autofix for TrailingComma in arrays/hashes
luke-hill Aug 22, 2024
00d5d22
Merge branch 'main' into refactor/gherkin_autofix_cops
luke-hill Sep 10, 2024
526b7b2
Regen the TODO file
luke-hill Sep 10, 2024
9fe56c2
Update berp version in docs
luke-hill Sep 11, 2024
e7adc10
Updated razor and generation debug with gaspar
luke-hill Sep 11, 2024
1888e60
Revert "Updated razor and generation debug with gaspar"
gasparnagy Sep 11, 2024
7a7acbc
allow extra indent for lookahead hint
gasparnagy Sep 11, 2024
a8f187f
remove spaces in newline
gasparnagy Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,7 @@ This document is formatted according to the principles of [Keep A CHANGELOG](htt

## [Unreleased]
### Added
- [PHP] update dependency messages up to v26 ([#268](https://github.com/cucumber/gherkin/pull/268))
- [JavaScript] update dependency messages up to v26 ([#268](https://github.com/cucumber/gherkin/pull/268))
- [JavaScript] update dependency messages up to at least v19.1.4 ([#268](https://github.com/cucumber/gherkin/pull/268))
- [Java] update dependency messages up to v26 ([#269](https://github.com/cucumber/gherkin/pull/269))
- [Ruby] update dependency messages up to v26 ([#267](https://github.com/cucumber/gherkin/pull/267))
- [PHP, Java, Ruby, JavaScript] update dependency messages up to v26

### Changed
- [.NET] Drop unsupported frameworks. Now supported target frameworks are .NET 8, .NET Standard 2.0 ([#265](https://github.com/cucumber/gherkin/pull/265))
Expand All @@ -21,6 +17,7 @@ This document is formatted according to the principles of [Keep A CHANGELOG](htt
- [.NET] Adopt c# 10 ImplicitUsings
- [.NET] Replace TinyJson to System.Text.Json
- [.NET] Enable warnings as errors
- [Ruby] Initial rubocop autofixes (Mainly to style) ([#266](https://github.com/cucumber/gherkin/pull/266))

## [29.0.0] - 2024-08-12
### Added
Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ docker run --rm --interactive --tty --volume ".:/app" berp-env
*Or* install on your system

* .NET 5.0 (to run `berp` to generate parsers)
* `berp` (install with `dotnet tool update Berp --version 1.3.0 --tool-path /usr/bin` )
* `berp` (install with `dotnet tool update Berp --version 1.4.0 --tool-path /usr/bin` )
* `make`
* `diff`

Expand All @@ -47,7 +47,7 @@ make generate

## Adding or updating an i18n language

1) Edit `gherkin-langauges.json`.
1) Edit `gherkin-languages.json`.

2) Distribute the changes to the different parser implementations:

Expand Down
4 changes: 4 additions & 0 deletions ruby/.rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,7 @@ AllCops:
# Display cop name / style guide references
DisplayCopNames: true
DisplayStyleGuide: true

# TODO: [LH] - Investigate this in terms of it not being fixed in rubocop?
Naming/MethodName:
Enabled: false
Loading