Add hook type #224
Closed
Add hook type #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hooks in Cucumber can either execute before/after a scenario or before/after a step. Depending on which implementation is used these are put into the json report as either all part of the `element.steps` field[1] or the `element.before` and `element.steps` fields[2][3]. So to create a json reports from messages the type of hook must be included in the message. 1. https://github.com/cucumber/cucumber-json-converter/blob/main/testdata/cucumber-js/7.3.2/json/failing-before-hook.json 2. https://github.com/cucumber/cucumber-json-converter/blob/main/testdata/cucumber-jvm/7.2.3/json/failing-before-hook.json 3. https://github.com/cucumber/cucumber-json-converter/blob/main/testdata/cucumber-jvm/7.2.3/json/failing-after-step-hook.json
|
As/when you get this in a spot to be merged let me know as I'll start getting my stuff ready too as then it'll be a decent time for a chunky major release (My stuff is breaking but small). |
|
It will be a while. I'm doing this for the JSON formatter, but that thing is overly complicated. And I'm getting side tracked with other projects in the same vein that are easier. |
|
@mpkorstanje is this now redundant by #102 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚡️ What's your motivation?
Hooks in Cucumber can either execute before/after a scenario or before/after a step. Depending on which implementation is used these are put into the json report as either all part of the
element.stepsfield[1] or theelement.beforeandelement.stepsfields[2][3].So to create a json reports from messages the type of hook must be included in the message.
Fixes: #72
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
Feel free.
📋 Checklist: