Refactored so that the dependency on System.Text.Json is removed from Cucumber.Messages deployable. #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he Specs testing project only. The Cucumber.Messages project no longer has a dependency on it.
1 task
|
Cheers! Looks good. |
|
@clrudolphi Do you have any breaking changes in mind? If not, we can make a release. @luke-hill I don't think you have any breaking changes in the pipeline. Is that correct? |
|
No. No breaking changes as none of this had been previously released. |
|
No I meant, on top of the current state. I would rather not make a new major release and 5 minutes later yet another. 😄 |
|
Oh. No. No further changes planned.
Chris
…________________________________
From: M.P. Korstanje ***@***.***>
Sent: Friday, August 2, 2024 2:20:45 PM
To: cucumber/messages ***@***.***>
Cc: Chris Rudolphi ***@***.***>; Mention ***@***.***>
Subject: Re: [cucumber/messages] Refactored so that the dependency on System.Text.Json is removed from Cucumber.Messages deployable. (PR #241)
No I meant, on top of the current state. I would rather not make a new major release and 5 minutes later yet another. 😄
—
Reply to this email directly, view it on GitHub<#241 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAM7YMU6JBUZG2H2BMJESJTZPPLY3AVCNFSM6AAAAABLWQWCR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRWGAYDKNBVGM>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Okay. Luke would like to finish his refactoring (#233 (comment)) and then we can release. Apologies for the hold up. Normally we can release more quickly because the project is relatively quite. |
clrudolphi
deleted the
Dotnet-RemoveDeploymentDependencyOnSystemTextJson
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Moved the dependency to the Specs testing project only. The Cucumber.Messages project no longer has a dependency on System.Text.Json.
⚡️ What's your motivation?
.NET implementations of Cucumber either take a dependency on an older version of the System.Text.Json library or want to avoid consuming libraries (such as this one) that hardwire such dependencies.
🏷️ What kind of change is this?
📋 Checklist:
< CHANGELOG already includes the refactoring of the DotNet implementation as an unreleased item. I felt an additional entry just for this was unwarranted.>
This text was originally generated from a template, then edited by hand. You can modify the template here.