cue: remove use of isDef

This seems unnecessary as the definition status is passed down to the Closed field. It also seems incorrect. Removing it has no effect and seems to run slightly faster. Change-Id: I79d9d1fd962310f1c78af7cf58e9e51c685e1d8b Reviewed-on: https://cue-review.googlesource.com/c/cue/+/9574 Reviewed-by: CUE cueckoo <[email protected]> Reviewed-by: Paul Jolly <[email protected]>
cuelang · Apr 30, 2021 · 5481b41 · 5481b41
1 parent ed5cdf0
commit 5481b41
Showing 1 changed file with 1 addition and 10 deletions.
diff --git a/cue/types.go b/cue/types.go
@@ -1777,17 +1777,8 @@ func (v hiddenValue) Subsumes(w Value) bool {
 	return p.Check(ctx, v.v, w.v)
 }
 
-func isDef(v *adt.Vertex) bool {
-	for ; v != nil; v = v.Parent {
-		if v.Label.IsDef() {
-			return true
-		}
-	}
-	return false
-}
-
 func allowed(ctx *adt.OpContext, parent, n *adt.Vertex) *adt.Bottom {
-	if !parent.IsClosedList() && !parent.IsClosedStruct() && !isDef(parent) {
+	if !parent.IsClosedList() && !parent.IsClosedStruct() {
 		return nil
 	}