cue: get rid of NewRuntime

It exposes an internal type that is no longer necessary. Change-Id: Ia683a0986bc43a39bef751406f9e9e8529fc3b70 Reviewed-on: https://cue-review.googlesource.com/c/cue/+/9422 Reviewed-by: CUE cueckoo <[email protected]> Reviewed-by: Paul Jolly <[email protected]>
cuelang · Apr 21, 2021 · 790bed3 · 790bed3
1 parent 64ede63
commit 790bed3
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 16 deletions.
diff --git a/cue/build.go b/cue/build.go
@@ -177,12 +177,6 @@ func (r *Runtime) FromExpr(expr ast.Expr) (*Instance, error) {
 	})
 }
 
-// NewRuntime creates a *runtime.Runtime with builtins preloaded.
-func NewRuntime() *runtime.Runtime {
-	i := newIndex()
-	return i
-}
-
 // newIndex creates a new index.
 func newIndex() *runtime.Runtime {
 	return runtime.New()

diff --git a/internal/core/adt/eval_test.go b/internal/core/adt/eval_test.go
@@ -22,10 +22,10 @@ import (
 
 	"github.com/rogpeppe/go-internal/txtar"
 
-	"cuelang.org/go/cue"
 	"cuelang.org/go/internal/core/adt"
 	"cuelang.org/go/internal/core/debug"
 	"cuelang.org/go/internal/core/eval"
+	"cuelang.org/go/internal/core/runtime"
 	"cuelang.org/go/internal/core/validate"
 	"cuelang.org/go/internal/cuetest"
 	"cuelang.org/go/internal/cuetxtar"
@@ -49,7 +49,7 @@ func TestEval(t *testing.T) {
 		test.ToDo = nil
 	}
 
-	r := cue.NewRuntime()
+	r := runtime.New()
 
 	test.Run(t, func(t *cuetxtar.Test) {
 		a := t.ValidInstances()
@@ -115,7 +115,7 @@ module: "example.com"
 		t.Fatal(instance.Err)
 	}
 
-	r := cue.NewRuntime()
+	r := runtime.New()
 
 	v, err := r.Build(instance)
 	if err != nil {

diff --git a/internal/core/export/export_test.go b/internal/core/export/export_test.go
@@ -42,7 +42,7 @@ func TestDefinition(t *testing.T) {
 		Update: cuetest.UpdateGoldenFiles,
 	}
 
-	r := cue.NewRuntime()
+	r := runtime.New()
 
 	test.Run(t, func(t *cuetxtar.Test) {
 		a := t.ValidInstances()

diff --git a/internal/core/export/extract_test.go b/internal/core/export/extract_test.go
@@ -18,11 +18,11 @@ import (
 	"fmt"
 	"testing"
 
-	"cuelang.org/go/cue"
 	"cuelang.org/go/internal/core/adt"
 	"cuelang.org/go/internal/core/compile"
 	"cuelang.org/go/internal/core/eval"
 	"cuelang.org/go/internal/core/export"
+	"cuelang.org/go/internal/core/runtime"
 	"cuelang.org/go/internal/cuetest"
 	"cuelang.org/go/internal/cuetxtar"
 )
@@ -34,7 +34,7 @@ func TestExtract(t *testing.T) {
 		Update: cuetest.UpdateGoldenFiles,
 	}
 
-	r := cue.NewRuntime()
+	r := runtime.New()
 
 	test.Run(t, func(t *cuetxtar.Test) {
 		a := t.ValidInstances()

diff --git a/internal/core/export/value_test.go b/internal/core/export/value_test.go
@@ -18,7 +18,6 @@ import (
 	"fmt"
 	"testing"
 
-	"cuelang.org/go/cue"
 	"cuelang.org/go/cue/ast"
 	"cuelang.org/go/cue/errors"
 	"cuelang.org/go/internal/core/adt"
@@ -43,7 +42,7 @@ func TestValue(t *testing.T) {
 		Skip:   exclude,
 	}
 
-	r := cue.NewRuntime()
+	r := runtime.New()
 
 	test.Run(t, func(t *cuetxtar.Test) {
 		a := t.ValidInstances()

diff --git a/pkg/internal/builtintest/testing.go b/pkg/internal/builtintest/testing.go
@@ -18,10 +18,10 @@ import (
 	"fmt"
 	"testing"
 
-	"cuelang.org/go/cue"
 	"cuelang.org/go/cue/format"
 	"cuelang.org/go/internal/core/eval"
 	"cuelang.org/go/internal/core/export"
+	"cuelang.org/go/internal/core/runtime"
 	"cuelang.org/go/internal/core/validate"
 	"cuelang.org/go/internal/cuetxtar"
 )
@@ -32,7 +32,7 @@ func Run(name string, t *testing.T) {
 		Name: name,
 	}
 
-	r := cue.NewRuntime()
+	r := runtime.New()
 
 	test.Run(t, func(t *cuetxtar.Test) {
 		a := t.ValidInstances()