Remove dependence on session column #77
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njakobsen
force-pushed
the
master
branch
4 times, most recently
from
70f45b3 to
2f5ba63
Compare
It appears that mimemagic v0.3.5 is no longer available.
njakobsen
force-pushed
the
remove-dependence-on-session-column
branch
4 times, most recently
from
e62a9ff to
4436604
Compare
By setting a session variable before we start recording entries for a commit we can ensure that entries are added with the correct `commit_id` instead of having to set the `commit_id` at the end of the commit. This in turn avoids issues where unexpected program termination could leave the commit entries in a state where the commit was not completed and its commits did not have a `commit_id`, making it impossible to know whether they are part of a commit or not. It was necessary to add a `capturing` column to simplify the exclusion of commit entries that are in the process of being captured. This eliminates complex querying when detecting autosyncable entries because we can just ignore any entries that are marked as capturing.
This may help with forensic analysis in the event of an error.
njakobsen
force-pushed
the
remove-dependence-on-session-column
branch
from
4436604 to
6986a62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
containedscope will no longer avoid this problem since we now always ensure thecommit_idis present. We could possibly add a new columncommittedand populate that column only when the commit is ended, similar to how we did for thecommit_id.By setting a session variable before we start recording entries for a commit we can ensure that entries are added with the correct
commit_idinstead of having to set thecommit_idat the end of the commit. This in turn avoids issues where unexpected program termination could leave the commit entries in a state where the commit was not completed and its commits did not have acommit_id, making it impossible to know whether they are part of a commit or not.