Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scrolling on touchscreens #28

Merged
merged 3 commits into from
Nov 17, 2022
Merged

Conversation

Pajn
Copy link

@Pajn Pajn commented Aug 13, 2022

Makes the slider work on touchscreens by allowing the browser to handle the y-axis

Fixes #27

Copy link
Member

@rohankapoorcom rohankapoorcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Pajn - it looks like your build.lock file is rolling back some of the upgrades that were recently released on the upstream branch. Can you revert the change to that file?

The rest of this looks great!

@Pajn
Copy link
Author

Pajn commented Aug 16, 2022

lockfile reverted

@ScottG489
Copy link

@rohankapoorcom Would love to see this go through! I love the look and compactness of these cards over mushroom cards, but this is a pretty big annoyance on phones. Don't want to accidentally set my thermostat to 90 and not notice while trying to scroll real quick on my dashboard :)

@Jimmypl007
Copy link

@rohankapoorcom Would love to see this go through!

In the meantime, they just added subviews to home assistant..

I have my lights and other slider controls in those at the moment.

@Pajn Pajn closed this Nov 17, 2022
@ScottG489
Copy link

Hey @Pajn! Wondering what the reason was that you closed this? Was looking forward to this change.

@Pajn
Copy link
Author

Pajn commented Nov 17, 2022

Cleaning a lot stalled PRs to make overview of open ones in https://github.com/pulls usable. It doesn't seem I can do enything more to get thi merged. Anyone is of course super free to pick this up if they see a way forward to get it mergerd.

@ScottG489
Copy link

It's too bad no one reviewed this. I'm just considering forking the repo with this change applied.

@BlackCube4
Copy link

Damn it, this is such a simple and fundamental feature. I would love this change!

@rohankapoorcom
Copy link
Member

Hey @Pajn - sorry for the delay on this. Things have been crazy for me the last couple of months.

@rohankapoorcom rohankapoorcom merged commit 86fadf5 into custom-cards:main Nov 17, 2022
@ScottG489
Copy link

Thanks so much @rohankapoorcom! When can we expect the next HACS release?

@piit79
Copy link

piit79 commented Nov 18, 2022

Awesome! Can't wait for the next release :) Thanks!

@rohankapoorcom
Copy link
Member

It was just released in v1.10.10

@mainmind83
Copy link

mainmind83 commented Nov 21, 2022

This fix seems to fail on all shutter elements, so far it worked. It does not allow to select above the percentage in Android

slider_button-card.mp4

square: false columns: 2
type: grid cards:
- type: custom:slider-button-card entity: light.0xcc86ecfffe4e988c_l2
slider: direction: left-right
background: gradient use_state_color: true
use_percentage_bg_opacity: false show_track: false
toggle_on_click: false force_square: false
show_name: true show_state: true
compact: false icon:
show: false use_state_color: false
tap_action: action: more-info
action_button: mode: toggle
icon: mdi:power show: true
show_spinner: true tap_action:
action: toggle name: Luz test 2

@Tammarko
Copy link

This fix seems to fail on all shutter elements, so far it worked. It does not allow to select above the percentage in Android

Confirming same behaviour, the shutters are now difficult to control.

@rohankapoorcom
Copy link
Member

Hey @Pajn - do you mind taking a look at this bug report with the cover elements?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slider doesn't allow scrolling up and down on touchscreen
8 participants