-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix scrolling on touchscreens #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Pajn - it looks like your build.lock file is rolling back some of the upgrades that were recently released on the upstream branch. Can you revert the change to that file?
The rest of this looks great!
lockfile reverted |
@rohankapoorcom Would love to see this go through! I love the look and compactness of these cards over mushroom cards, but this is a pretty big annoyance on phones. Don't want to accidentally set my thermostat to 90 and not notice while trying to scroll real quick on my dashboard :) |
In the meantime, they just added subviews to home assistant.. I have my lights and other slider controls in those at the moment. |
Hey @Pajn! Wondering what the reason was that you closed this? Was looking forward to this change. |
Cleaning a lot stalled PRs to make overview of open ones in https://github.com/pulls usable. It doesn't seem I can do enything more to get thi merged. Anyone is of course super free to pick this up if they see a way forward to get it mergerd. |
It's too bad no one reviewed this. I'm just considering forking the repo with this change applied. |
Damn it, this is such a simple and fundamental feature. I would love this change! |
Hey @Pajn - sorry for the delay on this. Things have been crazy for me the last couple of months. |
Thanks so much @rohankapoorcom! When can we expect the next HACS release? |
Awesome! Can't wait for the next release :) Thanks! |
It was just released in v1.10.10 |
This fix seems to fail on all shutter elements, so far it worked. It does not allow to select above the percentage in Android slider_button-card.mp4
|
Confirming same behaviour, the shutters are now difficult to control. |
Hey @Pajn - do you mind taking a look at this bug report with the cover elements? |
Makes the slider work on touchscreens by allowing the browser to handle the y-axis
Fixes #27