Feat: Reconfiguration config flow #434
Conversation
use mount instead of relying on PYTHONPATH to find integration
bj00rn
force-pushed
the
feat/reconfiguration-flow
branch
from
380e2b6
to
ec3b21a
Compare
| @@ -10,12 +10,6 @@ if [[ ! -d "${PWD}/config" ]]; then | |||
| hass --config "${PWD}/config" --script ensure_config | |||
| fi | |||
|
|
|||
There was a problem hiding this comment.
This change is from PR #431. I've replaced usage of pythonpath with mounting custom_components in the devcontainer. Downside is that this only works inside the devcontainer.
It seems that setting adding integration to pythonpath will cause the integration package to shadow nordpool dependency, since pythonpath has precedence over site-packages. Integration will not load. See discussion here ludeeus/integration_blueprint#130
import nordpool will point to the integration itself. I don't now if/why this was working in the earlier version of the devcontainer. Maybe some internal has changed in HASS, or if this relates to changes in python 3.12
|
This looks very nice, i have not been able to test it so it will not make the new release for today but this is a really nice feature. I will review and merge in 0.0.17 :) |
This PR is based on #431 since reconfigure flow is a 2024.4 feature. It will have to be rebased when #431 is merged. I think this PR needs some testing before it can be merged. Especially the entity naming. A new entity will be created when changing settings since named is derived from VAT, currency etc |
DON'T MERGE before #431
Add reconfiguration flow
fixes #102
Requires some more testing.. Based on #431