Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close method #31

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Close method #31

wants to merge 3 commits into from

Conversation

jatinn
Copy link
Contributor

@jatinn jatinn commented Jan 20, 2017

  • since warnings are enabled when a script exits a ResourceWarning: unclosed socket is displayed added a close method which will close the underlying socket.
  • replaced README.md with README.rst
  • version bump to 0.2.3

hownowstephen
hownowstephen requested changes Feb 3, 2017
View reviewed changes
Copy link
Contributor

@hownowstephen hownowstephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to add support for the with statement in this change, otherwise looks good to me

@dbader dbader mentioned this pull request Sep 19, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hownowstephen hownowstephen hownowstephen requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jatinn @hownowstephen