Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update use_connection_pooling (False) to address session overwriting #94

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update use_connection_pooling (False) to address session overwriting #94

wants to merge 2 commits into from

Conversation

rollerbrick
Copy link

When using CustomerIO with use_connection_pooling set to False the following error is occasionally produced. This PR changes use_connection_pooling (False) so it doesn't use self._current_session.

Traceback (most recent call last):
  ...
  File "...customerio/track.py", line 72, in identify
    self.send_request('PUT', url, kwargs)
  File "...customerio/client_base.py", line 55, in send_request
    self._close()
  File "...customerio/client_base.py", line 112, in _close
    self._current_session.close()
AttributeError: 'NoneType' object has no attribute 'close'

@wolever wolever mentioned this pull request Sep 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rollerbrick