Skip to content

Commit

Permalink
Contents of reachable statics is reachable
Browse files Browse the repository at this point in the history
  • Loading branch information
tmiasko committed Aug 22, 2023
1 parent 3e9e574 commit 0383131
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 7 deletions.
10 changes: 3 additions & 7 deletions compiler/rustc_passes/src/reachable.rs
Original file line number Diff line number Diff line change
Expand Up @@ -98,15 +98,11 @@ impl<'tcx> Visitor<'tcx> for ReachableContext<'tcx> {
self.worklist.push(def_id);
} else {
match res {
// If this path leads to a constant, then we need to
// recurse into the constant to continue finding
// items that are reachable.
Res::Def(DefKind::Const | DefKind::AssocConst, _) => {
// Reachable constants and reachable statics can have their contents inlined
// into other crates. Mark them as reachable and recurse into their body.
Res::Def(DefKind::Const | DefKind::AssocConst | DefKind::Static(_), _) => {
self.worklist.push(def_id);
}

// If this wasn't a static, then the destination is
// surely reachable.
_ => {
self.reachable_symbols.insert(def_id);
}
Expand Down
4 changes: 4 additions & 0 deletions tests/ui/cross-crate/auxiliary/static_init_aux.rs
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
pub static V: &u32 = &X;
pub static F: fn() = f;
pub static G: fn() = G0;

static X: u32 = 42;
static G0: fn() = g;

pub fn v() -> *const u32 {
V
}

fn f() {}

fn g() {}
3 changes: 3 additions & 0 deletions tests/ui/cross-crate/static-init.rs
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
// Regression test for #84455 and #115052.
// run-pass
// aux-build:static_init_aux.rs
extern crate static_init_aux as aux;

static V: &u32 = aux::V;
static F: fn() = aux::F;
static G: fn() = aux::G;

fn v() -> *const u32 {
V
Expand All @@ -12,4 +14,5 @@ fn v() -> *const u32 {
fn main() {
assert_eq!(aux::v(), crate::v());
F();
G();
}

0 comments on commit 0383131

Please sign in to comment.