-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GCS bucket name validation #7227
Conversation
@jootten, Hello, thank you for the contribution! Looks like it also affects attaching AWS S3 buckets. Could you please add |
It looks like Azure does not support dots. I would suggest adding an explicit condition for AWS. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #7227 +/- ##
===========================================
+ Coverage 81.51% 81.77% +0.25%
===========================================
Files 365 366 +1
Lines 39261 39355 +94
Branches 3631 3641 +10
===========================================
+ Hits 32004 32182 +178
+ Misses 7257 7173 -84
|
Co-authored-by: Maria Khrustaleva <maria@cvat.ai>
Co-authored-by: Maria Khrustaleva <maria@cvat.ai>
Motivation and context
It is not possible to attach a GCS cloud storage bucket which name contains a dot. As stated here, GCS bucket names allow dots. This is a major problem for us, and this PR fixes this issue.
How has this been tested?
No tests required.
Checklist
develop
branch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.