Added EigenPlaces for retrieval #337
Merged
+20
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @sarlinpe !
Following our conversation on the CosPlace PR, I have now changed the file
hloc/extractors/cosplace.py
withhloc/extractors/eigenplaces.py
and added avariant
config entry that can be switched between CosPlace and EigenPlaces (with the latter as default).Here are the results on Aachen, although they don't really show much difference between NetVLAD and EigenPlaces, although I believe this might be due to Aachen being saturated (there were similar results with CosPlace).