Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A patch with all new files & directories creates with a b/ prefix #199

Closed
pwolanin opened this issue Mar 20, 2018 · 5 comments
Closed

A patch with all new files & directories creates with a b/ prefix #199

pwolanin opened this issue Mar 20, 2018 · 5 comments

Comments

@pwolanin
Copy link

Seeing this with version 1.6.4

I have a path for a contrib module:

Config schema #2918157
Source: https://www.drupal.org/files/issues/entity-reference-uuid-schema.patch

when this patch is applied the files end up nested an extra level in a b/ subdirectory.

Possibly this is because all the files and directories are new, so the patch can apply while creating the directory and -p0?
@pwolanin
Copy link
Author

Correction - the patch was committed by the maintainer, so -p1 doesn't apply but -p0 does by making the b/ directory

@mdonadio
Copy link

Seeing this too. Believe it is this dependency, https://github.com/contentacms/contenta_jsonapi, which specific this patch, https://www.drupal.org/files/issues/drupal-n2788777-105.patch

@solariel
Copy link

Same problem with https://www.drupal.org/files/issues/2570593-30.patch
all new files are created twice.

image

@ixisandyr
Copy link

ixisandyr commented Apr 24, 2018 •
edited
Loading

Could be related to #43

@cweagans
Copy link
Owner

cweagans commented Jun 2, 2018

Dupe of #43.

@cweagans cweagans closed this as completed Jun 2, 2018
adam-dg pushed a commit to adam-dg/d8-quickstart that referenced this issue Nov 25, 2018
Fixing an issue since 1.6.4 of cweagans/composer-patches where Compos…
38d513f 
…er Patches struggles with patches that introduce new file. The solution is to upgrade to the 1.x-dev branch of Composer Patches and add some extra config to Composer.json

See:
- cweagans/composer-patches#199
- cweagans/composer-patches#43
- cweagans/composer-patches#101
- rwohleb/composer-patches#1
@adam-dg adam-dg mentioned this issue Nov 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@cweagans @pwolanin @ixisandyr @solariel @mdonadio