2.x todo

[cweagans]

This should probably be a bunch of separate tickets in a milestone, but I don't feel like it. This is easier:

2.0.0 release blockers

• Build passing
• 100% code coverage for all business logic (excl: composer boilerplate)
• Identify 5 acceptance test scenarios for core functionality + build those tests
• Docs
  • Troubleshooting guide (Troubleshooting guide #198)
  • Configuration & usage
  • Requirements (OS support, software dependencies, etc)
  • Extension points (events, capabilities)
  • docs only: how to apply patches to the root package/non composer packages (Apply patch on root folder #76)
• CLI command for adding patches (CLI command for adding patches #81)
• Define patch depth per-patch (extended format only)
• Implement -p guessing for when patch depth isn't specified (but fail if multiple depths can be successfully applied)
• Prevent interactive mode (Prevent interactive mode using the --batch flag #196)
• checkPatches() is too heavy handed (Adding new patch sometimes deletes other modules listed for patching #135)
• Dispatch events where needed
• composer-preserve-paths must work (Patched projects will be deleted and re-downloaded and patched #42)
• Allow ignoring specific patches (port to 2.x)
• Allow ignoring all patches on a package (port to 2.x)
• Make sure composer lock behavior is respected (Composer patches only respects composer.json #12)
• Remove dependency patch resolution

Wishlist

• Split out patch resolution into composer capabilities (Split out patch resolution into Composer Capabilities #212)
• Remove patch report generation (Make generating PATCHES.txt conditional #140)
• Dedupe patches based on sha1
• Unbreak FreeBSD (Fix a Unix breaking bug caused by a hack #184, Issue on FreeBSD #159, Patch works locally but fail on server #74) ?
• Address patcher issues (Use patch instead of git apply #172)
• Composer install fails with contrib project and bad patch (Composer install fails with contrib project and bad patch #127)
• Allow disabling removal of patched packages (Removing projects has no fallbacks #126)
• checkPatches should diff what's in composer.lock and composer.json, and if there's a mismatch, remove the package and reinstall it if appropriate (Force update on packages with new or changed patches #98
• Cache downloaded patches (Cache downloaded patches #35)
• Allow force-enabling patching to just have dependency patches (Patches in packages not installed unless root-level composer.json defines a patches key in extra. #16)
• Research: pure PHP implementation of Patch?
• Local patches defined by dependencies should be relative to the root of the dependency (File based patches aren't resolved in dependencies #39
• Apply patch to arbitrary path (Apply patch on root folder #76)

Evaluate other packages and merge functionality

• https://packagist.org/packages/nathandentzau/composer-patches-dev
• https://packagist.org/packages/szeidler/composer-patches-cli
• vaimo/composer-patches

[cweagans]

Feel free to submit PRs for any of these things if they aren't checked off.

[marclaporte]

About "Research: Pure PHP implementation of patch?" -> The patch utility is not always available and thus, we'd like this to be handled by cweagans/composer-patches (directly or indirectly)

Would this work?
https://github.com/FMaz008/UnifiedDiffPatcher

Are you aware of any other suitable libs? Anything already on Packagist.org?

Thanks!

[geek-merlin]

Maybe copy in the patch defs too? [to lock file]

The whole patch? I'd say this can become too huge and a hash is enough.

EDIT: aah the reference... well that really makes sense.

[ElijahLynn]

This issue summary was updated last night here at DrupalCon and is up to date with new priorities for the 2.x release.

[cweagans]

I added some notes to https://github.com/cweagans/composer-patches/wiki/2.0.0-Architecture-Notes

[cweagans]

This is pretty outdated now.