Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make generating PATCHES.txt conditional #140

Closed
Sutharsan opened this issue Jul 12, 2017 · 3 comments
Closed

Make generating PATCHES.txt conditional #140

Sutharsan opened this issue Jul 12, 2017 · 3 comments

Comments

@Sutharsan
Copy link

Composer patches generates a PATCHES.txt file with info about the applied patch. In my view this info duplicates the patches section in composer.json which also documents the applied patches.

Further, having a PATCHES.txt may be a security vulnerability. I use composer-patches in a Drupal project, where the PATCHES.txt is web accessible. This exposes information about applied patches which I do not want to share.

I would like to see an option to disable generating the PATCHES.txt file.

Without this option, I have these work-arounds:

  • Remove the PATCHES.txt file with a post-install-cmd/post-update-cmd script
  • Add PATCHES.txt to .htaccess to prevent access to the files.
  • Add PATCHES.txt to gitignore (I add all project code to the repo)
@cweagans
Copy link
Owner

Good points. I'm more than happy to put this in 2.x. 1.x might be okay depending on the impact, but it would have to be a really small thing.

@cweagans
Copy link
Owner

cweagans commented Jun 2, 2018

This is on the 2.0.0 roadmap (see #93).

This was referenced Jun 2, 2018
@cweagans
Copy link
Owner

cweagans commented Jun 3, 2018

Patch report generation has been removed in master. I don't plan to add it back in unless people feel very strongly about it, and only as an optional thing at that point. This functionality will be replaced by a composer patch-list command.

@cweagans cweagans closed this as completed Jun 3, 2018
donquixote pushed a commit to donquixote/composer-patches that referenced this issue Mar 15, 2019
This is a backport of pull request cweagans#213 for issue cweagans#140.
The two commits from cweagans#213 have been squashed into one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants