Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 3.7, 2.x #69

Merged
merged 2 commits into from
Nov 12, 2021
Merged

Remove Python 3.7, 2.x #69

merged 2 commits into from
Nov 12, 2021

Conversation

rpothier
Copy link
Contributor

@rpothier rpothier commented Nov 10, 2021

End support for Python 2.x, remove Python 3.7
Also merged in the changes from @doodlesbykumbi from PR #70

DEPRECATION: Python 2.7 reached the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 is no longer maintained.
pip 21.0 will drop support for Python 2.7 in January 2021.
More details about Python 2 support in pip can be found at
https://pip.pypa.io/en/latest/development/release-process/#python-2-support

Desired Outcome

CI tests should pass.

Implemented Changes

Connected Issue/Story

Resolves #68

CyberArk internal issue link: insert issue ID

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

End support for Python 2.x

DEPRECATION: Python 2.7 reached the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 is no longer maintained.
pip 21.0 will drop support for Python 2.7 in January 2021.
More details about Python 2 support in pip can be found at
https://pip.pypa.io/en/latest/development/release-process/#python-2-support
@doodlesbykumbi
Copy link
Contributor

@rpothier I saw justification for 2.7 but wondering what's the reasoning behind removing 3.7 ?

Also includes PR #70

Standard on the base container image for running ansible tests
@rpothier rpothier force-pushed the update-python-verstion branch from 9cd04fa to 7e15293 Compare November 11, 2021 14:41
@rpothier rpothier self-assigned this Nov 11, 2021
@rpothier rpothier marked this pull request as ready for review November 11, 2021 14:43
@rpothier rpothier requested a review from a team as a code owner November 11, 2021 14:43
@doodlesbykumbi doodlesbykumbi merged commit 65dbd7b into main Nov 12, 2021
@doodlesbykumbi doodlesbykumbi deleted the update-python-verstion branch November 12, 2021 10:56
@doodlesbykumbi doodlesbykumbi restored the update-python-verstion branch November 12, 2021 10:56
@doodlesbykumbi doodlesbykumbi deleted the update-python-verstion branch November 12, 2021 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

CI is failing
2 participants