Skip to content
This repository has been archived by the owner on Dec 2, 2024. It is now read-only.

Bump ruby version #266

Merged
merged 2 commits into from
Feb 22, 2022
Merged

Bump ruby version #266

merged 2 commits into from
Feb 22, 2022

Conversation

doodlesbykumbi
Copy link
Contributor

@doodlesbykumbi doodlesbykumbi commented Jan 27, 2022

Desired Outcome

Broader compatibility of conjur-service-broker with ruby buildpacks in TAS

The previously pinned version of Ruby has reached end of life. To avoid compatibility issues with the service broker running on currently supported versions of TAS we are pinning to the currently supported 2.7

Unpin ruby buildpack in manifest.yml. This is to support the transition to pinning the Ruby version for the application to one that isn't about to reach end of life and is widely supported. This allows for greater flexibility in terms of the buildpack to use when running the application, and avoids things like online installation of the pinned buildpack.

Implemented Changes

Describe how the desired outcome above has been achieved with this PR. In
particular, consider:

  • What's changed? Why were these changes made?
  • How should the reviewer approach this PR, especially if manual tests are required?
  • Are there relevant screenshots you can add to the PR description?

Connected Issue/Story

Resolves #[relevant GitHub issue(s), e.g. 76]

CyberArk internal issue link: insert issue ID

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

The previously pinned version of Ruby has reached end of life. To avoid compatibility issues with the service broker running on currently supported versions of TAS we are pinning to the currently supported 2.7
@doodlesbykumbi doodlesbykumbi force-pushed the bump-ruby-version branch 6 times, most recently from 0318f28 to efe2e44 Compare February 22, 2022 12:34
This is to support the transition to pinning the Ruby version for the application to one that isn't about to reach end of life and is widely supported. This allows for greater flexibility in terms of the buildpack to use when running the application
@doodlesbykumbi doodlesbykumbi marked this pull request as ready for review February 22, 2022 13:05
@doodlesbykumbi doodlesbykumbi requested a review from a team as a code owner February 22, 2022 13:05
Copy link
Contributor

@szh szh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants