Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrong scaling on idle logo #35

Merged
merged 1 commit into from
Dec 2, 2022
Merged

fix: wrong scaling on idle logo #35

merged 1 commit into from
Dec 2, 2022

Conversation

Xurdejl
Copy link

@Xurdejl Xurdejl commented Dec 1, 2022

Before:
before

After:
after

@po5
Copy link

po5 commented Dec 2, 2022

Seems like this is taken from upstream maoiscat@bd9c789

Is it a better solution than the one that got merged into mpv? mpv-player/mpv@cc65b38
Feels like they're handling more problems (positioning?)

@cyl0 cyl0 merged commit c3a0044 into cyl0:main Dec 2, 2022
@Xurdejl
Copy link
Author

Xurdejl commented Dec 4, 2022

@po5 Oh, that seems like a better solution.
I made a new commit https://github.com/Xurdejl/ModernX/commit/064100652794ca258cbbd3c0200578bb0e8d465c and replaced the logo with the changes from mpv-player/mpv@cc65b38 which also adds the Santa hat.

@cyl0
Copy link
Owner

cyl0 commented Dec 4, 2022

Merged, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xurdejl @po5 @cyl0