-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional buttons to skip forward/back a fixed amount #5
Conversation
Looks good, though I think that this should definitely be added as an option rather than a default behaviour as this script aims to mirror the functionality of the default MPV OSC. |
For sure, I will add a config option. Do you think it should be enabled by default? I think it would be reasonable, since they are present in the default mpv osc's box layout mode. |
I'll also make the skip amount configurable |
Config parameter is `showjump`
- Picks icon for `jumpamount` = 5, 10, 30, otherwise default (no number) - For default forward icon, we have mirror the rewind icon as the font does not provide it - `jumpmode` is now `exact` by default
Done! Last questions are:
|
If that's the case then sure, we'lll have it enabled by default. |
Both of those are already the default as of the latest commit so you can go ahead and merge :) |
Great, thanks for contributing! |
This is what the chapter skip buttons used to do in the original modern. These buttons are added in addition to the chapter skip buttons so you can still skip around in a file with no chapters.
Preview:
Left Mouse Button skips 5 seconds
Shift+LMB can skip 1 frame
RMB can skip 1 minute
These could be made optional with a config setting.