Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional buttons to skip forward/back a fixed amount #5

Merged
merged 5 commits into from
Feb 14, 2022

Conversation

AlpyneDreams
Copy link

@AlpyneDreams AlpyneDreams commented Feb 12, 2022

This is what the chapter skip buttons used to do in the original modern. These buttons are added in addition to the chapter skip buttons so you can still skip around in a file with no chapters.

Preview:
preview

Left Mouse Button skips 5 seconds
Shift+LMB can skip 1 frame
RMB can skip 1 minute

These could be made optional with a config setting.

@cyl0
Copy link
Owner

cyl0 commented Feb 12, 2022

Looks good, though I think that this should definitely be added as an option rather than a default behaviour as this script aims to mirror the functionality of the default MPV OSC.

@AlpyneDreams
Copy link
Author

AlpyneDreams commented Feb 13, 2022

For sure, I will add a config option. Do you think it should be enabled by default? I think it would be reasonable, since they are present in the default mpv osc's box layout mode.

@AlpyneDreams
Copy link
Author

I'll also make the skip amount configurable

Config parameter is `showjump`
- Picks icon for `jumpamount` = 5, 10, 30, otherwise default (no number)
- For default forward icon, we have mirror the rewind icon as the font does not provide it
- `jumpmode` is  now `exact` by default
@AlpyneDreams
Copy link
Author

AlpyneDreams commented Feb 13, 2022

Done!

Last questions are:

  • Do we want to enable them by default (imo I don't see why not, but it's your call)
  • Should the button icons have numbers by default (supported for 5, 10, 30). I think the numbers look kind of small to me when not in fullscreen.

@cyl0
Copy link
Owner

cyl0 commented Feb 13, 2022

If that's the case then sure, we'lll have it enabled by default.
As for the numbers, I think it would be better to keep them unless the jump amount has been configured to be something other than 5, 10 or 30. The icon without the number isn't very intuitavie as to what it does, so I think it's better off keeping the number even if it's small.

@AlpyneDreams
Copy link
Author

Both of those are already the default as of the latest commit so you can go ahead and merge :)

@cyl0
Copy link
Owner

cyl0 commented Feb 14, 2022

Great, thanks for contributing!

@cyl0 cyl0 merged commit 333699c into cyl0:main Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants