Allow cycling through OSC visibility mode #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mpv sets the DEL key as the default keybinding to toggle the OSC. This never took effect because
visibility_mode()doesn't understand/accept "cycle" as its parameter. This patch fixes the issue and allows cycling the OSC visibility betweennever,autoandalways. This was available inosc.lua, but for some reason removed inmordenx.lua.Fixes one of the issues mentioned in #6.
The 2nd commit, "Expose
osc-visibilityvia shared-script-properties" allows scripts to tell what the current state of the OSC is. This was added in mpv-player/mpv@d2dd4ca.