Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: normalize Firefox CDP spawn message #30711

Merged
merged 1 commit into from
Dec 4, 2024
Merged

test: normalize Firefox CDP spawn message #30711

merged 1 commit into from
Dec 4, 2024

Conversation

mschile
Copy link
Contributor

@mschile mschile commented Dec 3, 2024

Additional details

Removed the Failed to spawn CDP with Firefox. Retrying (again)... from the system test output.

Steps to test

n/a

How has the user experience changed?

n/a

PR Tasks

@cypress Cypress
Copy link

cypress bot commented Dec 3, 2024

cypress    Run #58650

Run Properties:  status check passed Passed #58650  •  git commit 9fccae37e7: test: normalize Firefox CDP spawn message
Project cypress
Branch Review mschile/firefox_cdp_connection_message
Run status status check passed Passed #58650
Run duration 24m 03s
Commit git commit 9fccae37e7: test: normalize Firefox CDP spawn message
Committer Matthew Schile
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 4
Tests that did not run due to a developer annotating a test with .skip  Pending 1326
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 29400
View all changes introduced in this branch ↗︎
UI Coverage  46.24%
  Untested elements 188  
  Tested elements 166  
Accessibility  92.54%
  Failed rules  3 critical   8 serious   2 moderate   2 minor
  Failed elements 909  

AtofStryker
AtofStryker approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@AtofStryker AtofStryker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this!

@mschile mschile merged commit cdc9fe0 into develop Dec 4, 2024
83 of 86 checks passed
@mschile mschile deleted the mschile/firefox_cdp_connection_message branch December 4, 2024 18:14
@mschile mschile mentioned this pull request Dec 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AtofStryker AtofStryker AtofStryker approved these changes

@jennifer-shehane jennifer-shehane jennifer-shehane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove CDP failed to spawn messaging from snapshot checks
3 participants
@mschile @jennifer-shehane @AtofStryker